Hi Bernie, As far as we know, the prevous commit had been already blocked before we update commits. We only update the primitive service context and we leave the base layer without any modification. I expect you resolve the base layer break issue. If anything different from my understanding, let me know. BR, Uze Choi ------- Original Message ------- Sender : Keany, Bernie<bernie.keany at intel.com> Date : 2015-05-13 07:48 (GMT+09:00) Title : Re: [dev] Base Android API patch has been pushed for review
Hello Madan, We?re blocked because the last three commits have broken the Android API patch that was previously submitted, please resolve the build issues so that we can continue. As of this moment the build of the stack for Android is failing in services code, please verify and fix the failures. Thanks Bernie From: Madan Kanth Lanka <lanka.madan at samsung.com<mailto:[email protected]>> Reply-To: "lanka.madan at samsung.com<mailto:lanka.madan at samsung.com>" <lanka.madan at samsung.com<mailto:lanka.madan at samsung.com>> Date: Monday, May 11, 2015 at 11:51 PM To: "Kourt, Tim A" <tim.a.kourt at intel.com<mailto:tim.a.kourt at intel.com>> Cc: "iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org>" <iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org>> Subject: Re: [dev] Base Android API patch has been pushed for review Hi Tim, --> Ongoing development of the CA for android on master Could you please elaborate more? from CA team, we understand that current master source is enough to build for Android platform. Thanks, Madan ------- Original Message ------- Sender : Kourt, Tim A<tim.a.kourt at intel.com<mailto:tim.a.kourt at intel.com>> Date : May 09, 2015 06:14 (GMT+09:00) Title : RE: Re: [dev] Base Android API patch has been pushed for review Hi Madan, We have verified that https://gerrit.iotivity.org/gerrit/#/c/894/5 builds and runs as expected. Here is the command line that we have used to build it for android: scons TARGET_OS=android TARGET_ARCH=x86 RELEASE=0 TARGET_TRANSPORT=WIFI At the same time https://gerrit.iotivity.org/gerrit/#/c/894/6 fails to build. I would like to remind, that we advise against rebasing at this time due to the ongoing development of the CA for android on master. We are really hoping that this development can be finalized soon and we can adjust the Android API code accordingly. Meanwhile, we believe that patch set https://gerrit.iotivity.org/gerrit/#/c/894/5 has enough CA enabled (WiFi only) to allow for any android API related testing to proceed. Thank you, Tim Kourt PS: We continue to work with LF to enable Jenkins to build for android on their servers. From: Madan Kanth Lanka [mailto:[email protected]] Sent: Friday, May 8, 2015 2:50 AM To: Kourt, Tim A; Uze Choi Cc: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: Re: Re: [dev] Base Android API patch has been pushed for review Hi Tim, >Uze, would it be possible for you to amend the patch 894 to include the latest >fixes from android-api branch? Thereafter, we can completely abandon the >android-api branch and continue to review 894. Yes we can amend the patch 894 to include latest fixes. However, as current 894 commit is not compiling, we couldn't commit our fixes. After the compilation issues are fixed, we can push latest fixes. Thanks, Madan ------- Original Message ------- Sender : Kourt, Tim A<tim.a.kourt at intel.com<mailto:tim.a.kourt at intel.com>> Date : May 08, 2015 08:56 (GMT+09:00) Title : Re: [dev] Base Android API patch has been pushed for review The least desirable outcome is to have a broken services code on master for any period of time once the patch 894 is merged. Uze, would it be possible for you to amend the patch 894 to include the latest fixes from android-api branch? Thereafter, we can completely abandon the android-api branch and continue to review 894. As a reminder, we are waiting for the CA Android work to be finalized on master, therefore I would advise against rebasing at this moment as it will break the runtime and require some changes to be made in JNI and Java code. Regards, Tim Kourt -----Original Message----- From: iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org> [mailto:[email protected]] On Behalf Of Keane, Erich Sent: Thursday, May 7, 2015 9:27 AM To: uzchoi at samsung.com<mailto:uzchoi at samsung.com> Cc: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: Re: [dev] Base Android API patch has been pushed for review On Thu, 2015-05-07 at 18:40 +0900, ???(Uze Choi) wrote: > Hi Erich, > > My request looks like slightly different from your understanding. > > Change-894 has merge issue now and you need to update it with different patch. It'll definitely need to be rebased. There is an intent to do so. > When you update it, please include our today's works on android-api. > (Change 911, Change 910, Change 914 and so on.) These commits are already > merged into android-api branch. > If not, we need to figure out all difference in the base layer code between > android-api and master branch also. I was really hoping that you'd be willing to pull the Service differences over, because my attempts at merging last time (CA) and this time caused some pretty nasty issues with your code. Could you just cherry pick those reviews to master after 894 comes over? > > BR, Uze Choi > -----Original Message----- > From: Keane, Erich [mailto:erich.keane at intel.com] > Sent: Thursday, May 07, 2015 9:35 AM > To: uzchoi at samsung.com<mailto:uzchoi at samsung.com> > Cc: Keany, Bernie; iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at > lists.iotivity.org>; > brian.warner at linuxfoundation.org<mailto:brian.warner at > linuxfoundation.org> > Subject: Re: [dev] Base Android API patch has been pushed for review > > Responses inline: > > On Thu, 2015-05-07 at 09:28 +0900, ???(Uze Choi) wrote: > > Hi Berine/Tim > > > > I appreciate you your effort for android api working in base layer. > > Anyway, by today there will be couple of update from primitive > > services on android-api branch. > > Android-api branch is effectively closed as of this review. Any further > 'primative services' code should be done in a new review. > > > Please apply this change on this 894 commit by addon patch. > > > > We have a hard time for build check in android platform, As soon as > > possible, Jenkins buildboot system needs to check the android build > > together. (This is the request for IoTivity Infra team) > > We're working on that as we speak :) The Android build is enabled via the > build-script, but the build server needs gradle and the NDK installed > properly. > > > > Furthermore, I propose that android api should not be handled in a > > separate branch. > > Strictly, this is not feature, but platform support only. > > Every feature should consider it. > > Once this review goes in, android-api will be on master, so there will be no > 'separate brnach'. > > > > I was very hard to synchronize the code together with master branch. > > Whenever, CA code implemented in the CA branch, we need to check the > > code with that CA branch base layer code. > > And CA code was just into the master, we would have checked whether > > the service code aligned well to master branch again. > > I wish the android code need to be care from each feature code also > > not on the special android-api branch. > > > > BR, Uze Choi > > -----Original Message----- > > From: iotivity-dev-bounces at > > lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org> > > [mailto:iotivity-dev- > > bounces at lists.iotivity.org<mailto:bounces at lists.iotivity.org>] On > > Behalf Of Keany, Bernie > > Sent: Thursday, May 07, 2015 5:06 AM > > To: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at > > lists.iotivity.org> > > Subject: [dev] Base Android API patch has been pushed for review > > > > Yesterday we submitted https://gerrit.iotivity.org/gerrit/#/c/894/ > > for review, this changeset brings the Android API work which has > > been in progress on the android-api branch onto the master branch. > > There are a large number of changes and some modifications which are > > still in process as a result of the merging of the CA branch onto > > master followed by the merge of the android-api onto master. We?ve > > added some reviewers but want to make sure that the community is > > aware of the patch incase you?d like to add yourself as a reviewer. > > > > As I mentioned, there are still some areas where final modifications > > are in progress and those areas relate to the changes that will need > > to be made in the services in order to use the Base API as well as > > remaining CA merge items regarding the BLE and wifi interfaces. > > Other than that the code is comple and ready for review/comment. > > Please add yourself if you?re interested in reviewing. > > > > Thanks, > > Bernie Keany > > _______________________________________________ > > iotivity-dev mailing list > > iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at > > lists.iotivity.org> > > https://lists.iotivity.org/mailman/listinfo/iotivity-dev > > > > _______________________________________________ > > iotivity-dev mailing list > > iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at > > lists.iotivity.org> > > https://lists.iotivity.org/mailman/listinfo/iotivity-dev > > _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> https://lists.iotivity.org/mailman/listinfo/iotivity-dev _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> https://lists.iotivity.org/mailman/listinfo/iotivity-dev [http://www.samsung.net/service/ml/AttachController/201505121551410_Z5JE7EUA.gif?cmd=downdirectly&filepath=/LOCAL/ML/CACHE/u/20150512/BGFC2LL5XOK0 at namo.co.kr1211uzchoi&contentType=IMAGE/GIF;charset=UTF8&msgno=1211&partno=1&foldername=INBOX&msguid=188950]
