Em segunda-feira, 6 de junho de 2016, ?s 06:41:23 CDT, Gregg Reynolds escreveu: > Hi list, > > I've got a dozen or so minor fixes ready for review. Some of them > eliminate warnings, a couple count as bug fixes, and some are part of the > Darwin port. > > Do I really just pick reviewers at random? I only have the list at > https://gerrit.iotivity.org/gerrit/#/admin/groups/7,members to go on. > > Also how many reviewers to pick? Is one sufficient for small changes?
Hi Gregg Pick people who have worked on that code so they can give meaningful feedback. But you also need to pick at least one maintainer or sub-maintainer. They're the ones who have the power to give +2 to approve the change. See the table at the bottom of https://wiki.iotivity.org/projects_and_functions . -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center
