Yes there is an IoTivity wiki coding standards page but it does not have sufficient precision. For example, it only mentions not to use tabs, it contains little or no guidance about other forms of whitespace consistency.
That's why I'm proposing we mandate/automate use of uncrustify. > -----Original Message----- > From: Bell, Richard S [mailto:richard.s.bell at intel.com] > Sent: Saturday, June 25, 2016 2:41 PM > To: Macieira, Thiago <thiago.macieira at intel.com>; iotivity- > dev at lists.iotivity.org; Dave Thaler <dthaler at microsoft.com> > Subject: RE: [dev] uncrustify > > There is actual IoTivity Wki Coding Standard page... > https://wiki.iotivity.org/iotivity_coding_standards > > Our team use the Bulk C++ Formatting - Artistic Style tool script discussed on > the page. > Visual Studio say it is using Artistic Style which I would hope is the same > the > Bulk C++ Format but I have not actually used it. > > One caveat I noticed was the Eclipse IoTitity is not the same as the Bulk. > I agree these should be the same and Eclipse should probably be changed to > conform to Artistic Style tool My Team members who use Eclipse are > required to run their code through Artistic Style tool before checking in. > > Thanks, > Rick Bell > Senior Software Engineer > OTC UPnP/DLNA Software Team > Intel Corporation > (503) 712 8209 > > -----Original Message----- > From: iotivity-dev-bounces at lists.iotivity.org [mailto:iotivity-dev- > bounces at lists.iotivity.org] On Behalf Of Thiago Macieira > Sent: Friday, June 24, 2016 3:35 PM > To: iotivity-dev at lists.iotivity.org; Dave Thaler <dthaler at microsoft.com> > Subject: Re: [dev] uncrustify > > On sexta-feira, 24 de junho de 2016 21:42:43 PDT Dave Thaler via iotivity-dev > wrote: > > I'm seeing lots of whitespace problems where people either > > > > a) Insert tabs in C/C++ code, which the coding guidelines say is a > > no-no > > > > b) Have inconsistent spacing style in the same file > > > > Having come from the world of AllJoyn and other OSS projects, this > > makes iotivity look really ugly by comparison. Is there any reason why > > we can't do like they do and require running uncrustify before submission? > > > > For example in AllJoyn, jenkins will fail verification if uncrustify > > finds anything amiss. This makes the code more readable and consistent > > throughout. > > > > This is one of several things that I think need to be done to clean up > > iotivity. > > I support this idea. > > -- > Thiago Macieira - thiago.macieira (AT) intel.com > Software Architect - Intel Open Source Technology Center > > _______________________________________________ > iotivity-dev mailing list > iotivity-dev at lists.iotivity.org > https://lists.iotivity.org/mailman/listinfo/iotivity-dev
