First off, these patches were in master not in 1.2-rel, and it sounds like you?re talking about 1.2-rel. Second, there should not be any new features checked in that are not built in Jenkins, unless they?re experimental and not guaranteed to work. From: ???(Uze Choi) [mailto:[email protected]] Sent: Monday, September 19, 2016 8:19 PM To: Ferguson, Daniel J <daniel.j.ferguson at intel.com>; Dave Thaler <dthaler at microsoft.com>; ??? <dongik.lee at samsung.com> Cc: iotivity-dev at lists.iotivity.org Subject: [Action Request] RE: [dev] Request to revert the merged patches(#11227,#10743)
Hi Dave/Ferguson/Dongik Let me organize this issue because this is related with released feature. As Dongik(Security Guy) commented, with these two commit merges, 1.2 new feature is not compiled. https://gerrit.iotivity.org/gerrit/#/c/11227/ https://gerrit.iotivity.org/gerrit/#/c/10743/ This feature (Cloud provisioning) newly came into RC2. ?build with WITH_TCP = true and SECURE=true? should have been checked from Jenkins, To avoid drastic build option change, I had planned to apply this build option in the Jenkins from this week. Anyway, other two commits make this new feature not compiled now. so it is required to revert right now. Please understand this action, because this is required for new feature in this release. Revert Action need to be done follow 1. https://gerrit.iotivity.org/gerrit/#/c/11227/ revert. 2. After master merge, on top of there https://gerrit.iotivity.org/gerrit/#/c/10743/ revert. 3. After master merge, on top of there , Add Jenkins Job tcp, secure =1. 4. Undo revert https://gerrit.iotivity.org/gerrit/#/c/10743/ 5. Undo revert https://gerrit.iotivity.org/gerrit/#/c/11227/ I initially trigger the action for https://gerrit.iotivity.org/gerrit/#/c/11227/ revert. Please merge after verified. And https://gerrit.iotivity.org/gerrit/#/c/10743/ revert again. BR, Uze Choi (Release Management Function leader) From: iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org> [mailto:[email protected]] On Behalf Of ??? Sent: Monday, September 19, 2016 8:07 PM To: dthaler at microsoft.com<mailto:dthaler at microsoft.com> Cc: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: [dev] Request to revert the merged patches(#11227,#10743) Dear Dave, After merging the below patches, the current iotivity scons build with SECURED=1 WITH_TCP=1 WITH_CLOUD=1 results in failure. build error happens with commit id fef945f09258318fc799210618c7115648df51b3 https://gerrit.iotivity.org/gerrit/#/c/11227/ https://gerrit.iotivity.org/gerrit/#/c/10743/ Compiling out/linux/x86_64/release/resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.os resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.c:30:21: fatal error: camutex.h: No such file or directory compilation terminated. scons: *** [out/linux/x86_64/release/resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.os] Error 1 Basically, the above options should be successful. I am wondering why jenkins build script does not reflect for the regarding option for now. Could you revert the above patches and upload patch again after jenkins build option has been updated ? BR, Dongik ________________________________ Dongik LEE (Principal Engineer) Security Lab.(Software R&D Center) SAMSUNG ELECTRONICS CO.,LTD Mobile : +82-10-5091-8190 E-mail : dongik.lee at samsung.com<mailto:dongik.lee at samsung.com> ________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20160919/e3fb8dec/attachment.html>
