The list looks good to me. However, I believe headers for provisioning API 
still include iotivity_config.h (I logged IOT-2000), which will bring in more 
headers that I tried removed as part of my change you identified below. Since 
they are not intended to be public, I think your change is good as is.

Thanks,
Way

-----Original Message-----
From: Mats Wichmann [mailto:[email protected]] 
Sent: Tuesday, April 25, 2017 11:42 AM
To: Dave Thaler <dthaler at microsoft.com>; Way Vadhanasin <Wayakorn.Vadhanasin 
at microsoft.com>
Cc: IoTivity Developer List <iotivity-dev at lists.iotivity.org>
Subject: Updating header file list for CSDK (from: Change in iotivity[1.3-rel]: 
IOT-1994 Simplify OCStack public header file requirements)

A change pushed just now:

https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerrit.iotivity.org%2Fgerrit%2F%23%2Fc%2F18869%2F&data=02%7C01%7CWayakorn.Vadhanasin%40microsoft.com%7C2c58b8f2b45b45bfad5508d48c0ac6e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636287425302451811&sdata=NHpC2iV789PIeUFK5XtSW6iBo9BIjDFFMqfCR%2FbJiMQ%3D&reserved=0

would seem to change the requirements of which headers need to be a public part 
of the CSDK.  The change was to the actual include chains, but I'd like to make 
sure we look at the list for documentation as well...

I already had a small change pending in this area in:

https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerrit.iotivity.org%2Fgerrit%2F%23%2Fc%2F18485%2F6%2Fresource%2Fdocs%2Fc-doc%2FDoxyfile&data=02%7C01%7CWayakorn.Vadhanasin%40microsoft.com%7C2c58b8f2b45b45bfad5508d48c0ac6e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636287425302451811&sdata=mq2OQqKXiE4KQTCnzml8vpSY6vUoADxxe7QT6qQlmr0%3D&reserved=0

(part of a change submitted against master before 1.3 was branched, all this 
one does is exclude one file which is not a C header but sits in a directory 
otherwise included)

It doesn't look to me like the files listed in the change as no longer being 
needed were in the INPUT list in the Doxyfile anyway (which means it was not a 
properly closed set at the time), so maybe there is no change to be made, but 
if the experts can check that would be great!

Reply via email to