Hi C.J. Could you make a script to check it and trigger whenever commit happen? BR, Uze Choi -----Original Message----- From: [email protected] [mailto:iotivity-dev- bounces at lists.iotivity.org] On Behalf Of Stefan Schmidt Sent: Thursday, March 16, 2017 4:28 PM To: Mats Wichmann; IoTivity Developer List Subject: Re: [dev] please let's not change file modes carelessly
Hello. On 03/16/2017 12:43 AM, Mats Wichmann wrote: > > A pull on master just now shows: > > mode change 100644 => 100755 build_common/SConscript mode change > 100644 => 100755 build_common/tizen/SConscript mode change 100644 => > 100755 > resource/csdk/connectivity/build/tizen/packaging/com.oic.ca.spec > mode change 100644 => 100755 > resource/csdk/connectivity/build/tizen/scons/SConscript > mode change 100644 => 100755 > resource/csdk/connectivity/src/camessagehandler.c > mode change 100644 => 100755 resource/csdk/logger/SConscript mode > change 100644 => 100755 > resource/csdk/stack/samples/tizen/build/scons/SConscript > mode change 100644 => 100755 resource/csdk/stack/src/occlientcb.c > mode change 100644 => 100755 resource/csdk/stack/src/ocstack.c mode > change 100644 => 100755 tools/tizen/iotivity.spec > > None of these files should be mode 755. Do why know why they changed? > I can't seem to get git to tell me what the change was, not smart enough. In all cases I have seen this over the years the culprit have always been that the files have been created or changed on a Windows machine and git just kept the file modes when pushing (directly or to gerrit) > There are now 536 non-directory files with "execute permission" in the > tree, while only a very small number should have it (*.sh, *.bat, > etc.) Sounds like this needs a quick script magic run to fix the existing ones and more attention during review for the future. :) Or a git hook enforcing it if you want to go that way. regards Stefan Schmidt _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
