I strongly recommend reverting the change from the 1.3-rel build:
https://gerrit.iotivity.org/gerrit/#/c/19585

The commit message says that it is for Fixing compiler warnings from MSVC

The commit makes some large changes resulting in unforeseen consequences.

It changes the way integers are represented internally from int to int64_t 
although this may be a good change in the long run it should not be done on RC2 
this single change has introduced at least two release breaking bugs:

https://jira.iotivity.org/browse/IOT-2277 OcRepresentation usage is not broken 
in Java (release breaking)
https://jira.iotivity.org/browse/IOT-2251  OCRepresentation:getValue and 
OCRepresentation::setValue APIs are causing build error (release breaking)
https://jira.iotivity.org/browse/IOT-2233 Build error: can not convert 
OC:OCRepresentation::AttributeItem to <T> when gcc version is newer than v5 
(important to me personally since I am using gcc v6.3.1 on my primary dev 
computer)

3 major bugs reported for the change since it was merged 7 days ago.

Already two commits have been made to try and solve the problems introduced 
with one of them already being merged.
https://gerrit.iotivity.org/gerrit/#/c/19901/ [IOT-2251] **MERGED**
https://gerrit.iotivity.org/gerrit/#/c/19965/ [IOT-2233] **IN REVIEW**

The change made for https://gerrit.iotivity.org/gerrit/#/c/19585 is too big of 
a change for the release branch and should be reverted along with 
https://gerrit.iotivity.org/gerrit/#/c/19901/

I have no problems with the changes being moved to the master branch.


Not 100% sure but I think https://gerrit.iotivity.org/gerrit/#/c/19747/ may 
also have to be reverted if this change is reverted.

George Nash



-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20170517/36f9ae20/attachment.html>

Reply via email to