On 14/07/17 22:50, Gregg Reynolds wrote:


On Jul 14, 2017 3:38 PM, "Heldt-Sheller, Nathan" <[email protected] <mailto:[email protected]>> wrote:

    Hi Gregg,

    I agree that sample apps have to be maintained, so yes they should
    be fixed, when they are discovered to be broken.


I think they were broken since we turned on security, and also on 1.3-rel RCs too I noticed that at that time, but since there were ongoing works I didnt want to disturbs

Note that some examples never supported security:
https://jira.iotivity.org/browse/IOT-2505

Maybe others, please add "OC_STACK_UNAUTHORIZED_REQ" label to track those "regressions"

https://jira.iotivity.org/issues/?jql=labels%20%3D%20OC_STACK_UNAUTHORIZED_REQ


    *is to refer to the examples we’ve provided, update the .json
    files, re-encode the .dat files using json2cbor (see wiki) and try
    to get the samples working.*

re-encode on the fly is no more needed once those changes are merged (in master branch at least):

https://jira.iotivity.org/browse/IOT-2310

Developer still need to commit .dat files spotted different in source tree

A wiki page that explain those references .json files are welcome too

    In order to ensure the bug has a better chance of getting looked
    at, the two log files (client.log and server.log) from a debug
    build should also be attached to the JIRA ticket.



I think it would help to open a meta-bug regarding security and examples.

The good news is that I started to try to fix some of them,
Please review C++ example fix:

https://jira.iotivity.org/browse/IOT-2443
https://gerrit.iotivity.org/gerrit/#/c/21487/ my patch to enable SECURITY on C++ example under review

By the way, I shared simplified examples that could be used as tuturial
maybe it could help if you're too confused with examples in tree
http://git.s-osg.org/iotivity-example/plain/README.md

Stay tuned,



--
mailto:[email protected] gpg:0x467094BC
https://blogs.s-osg.org/author/pcoval/

_______________________________________________
iotivity-dev mailing list
[email protected]
https://lists.iotivity.org/mailman/listinfo/iotivity-dev

Reply via email to