Hi Phil, I agree your change has merits and I understand the motive... it was very bad to have the "reference" .dat files out of sync with their source .json files, and no way for devs to know. However:
>> Instead, I recommend adding a specific command that you run after the >> tool is run that copies the .dat files from out/ back into the source dir. > This is what I've done, > it's done by default, but it can be done on purpose I think it should be at the very least an option that can be disabled. E.g. like "UPDATE_DAT_FILES=0", so that if a dev is changing something that doesn't affect the .json, json2cbor, or .dat files, but a rebuild changes them, the dev doesn't have to push the new .dat files. Note that (separate issue I think) the gerrit commit extension seems to have automatically re-added the .dat files. I did a git status, saw the .dat files, did a git add of only the .c and .h files, and then the push still included the .dat files, which is how I noticed this was going on even on a typical build that didn't touch .json or the conversion tool. Thanks, Nathan -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Philippe Coval Sent: Monday, March 5, 2018 10:44 AM To: [email protected] Subject: Re: [dev] .dat files not being .gitignored? On 03/05/2018 07:36 PM, Thiago Macieira wrote: > On Monday, 5 March 2018 10:17:56 PST Philippe Coval wrote: >> Yes I introduced this "keep json and dat synched feature", in master >> while 1.3-rel was branched > Please don't do that. You should not modify checked-in files unless > the developer specifically wants to. I don't know if Nathan was > modifying the tool or if the .dat files were spuriously modified, but that's > not relevant. > > Instead, I recommend adding a specific command that you run after the > tool is run that copies the .dat files from out/ back into the source dir. This is what I've done, it's done by default, but it can be done on purpose > Whoever > runs this command will know about it and will add "updated .dat files" > to the commit message (if it isn't obvious that it was needed). git status will list the difference and then developer knows that he introduced a change then it's his duty to commit and push it. > > No one else needs to see those files being modified. Ever. Well then how will they be updated ? -- mailto:[email protected] gpg:0x467094BC https://blogs.s-osg.org/author/pcoval/ _______________________________________________ iotivity-dev mailing list [email protected] https://lists.iotivity.org/mailman/listinfo/iotivity-dev _______________________________________________ iotivity-dev mailing list [email protected] https://lists.iotivity.org/mailman/listinfo/iotivity-dev
