Hello :

I've noticed a little mistake when building 3.4.27 in my OpenBSD 3.1 /
Sparc64 box . Look at sparc64 portion of the 3.1-sys-diffs file ( in the
ip_fil3.4.27/OpenBSD directory ) :

diff -d -c -r /tmp/sys/arch/sparc64/sparc64/conf.c
sys/arch/sparc64/sparc64/conf.c
*** /tmp/sys/arch/sparc64/sparc64/conf.c        Fri Mar 15 12:46:11 2002
--- sys/arch/sparc64/sparc64/conf.c     Thu Apr 25 03:57:39 2002
***************
*** 120,125 ****
--- 120,131 ----
  #include "ucom.h"
  #include "uscanner.h"

+ #ifdef IPFILTER
+ #define NIPF 1
+ else                    / * ^^^^^^  look at this line ^^^^^^ */
+ #define NIPF 0
+ #endif
+
[snip]


In the block where NIPF is defined, there were a "#" missing before the
"else" sentence. This produces a failure in the kernel compilation as it
seems a redefinition in the variable.

Th 3.4.27-patch file has also the same mistake :

+ diff -d -c -r /tmp/sys/arch/sparc64/sparc64/conf.c
sys/arch/sparc64/sparc64/conf.c
+ *** /tmp/sys/arch/sparc64/sparc64/conf.c      Fri Mar 15 12:46:11 2002
+ --- sys/arch/sparc64/sparc64/conf.c   Thu Apr 25 03:57:39 2002
+ ***************
+ *** 120,125 ****
+ --- 120,131 ----
+   #include "ucom.h"
+   #include "uscanner.h"
+
+ + #ifdef IPFILTER
+ + #define NIPF 1
+ + else                    / * ^^^^^^  look at this line too ^^^^^^ */
+ + #define NIPF 0
+ + #endif
+ +
[snip]


If this line is modified ( to #else ) the kernel compiles cleanly.

Regards

Richard Cotrina

Reply via email to