Darren,

i had a quick look. It seems that one patch was somehow
omitted. You mentioned that you had a similar patch in
your tree, but somehow it didn't make it into the new
version.

-- Attila


I wrote:

> Hi,
>
> while i'm at it, here is another patch.
>
> If a servicename wasn't found in /etc/services
> no error was generated but port number 65535
> was used in the rule. The patch will fix this.



Darren Reed wrote:


I've also added a swag of other changes from people, addressing problems in return-rst/return-icmp generation, amongst others. Just to make sure they've all been applied properly, I'd appreciate it if people could have a look at:

http://coombs.anu.edu.au/~avalon/ip_fil4.1next.tar.gz

Cheers,
Darren


*** tools/ipf_y.y.orig  Tue Aug 24 19:58:11 2004
--- tools/ipf_y.y       Tue Aug 24 20:00:58 2004
***************
*** 1049,1057 ****
        ;

  portnum:
!       servicename                     { $$ = ntohs(getport(frc, $1));
                                          if ($$ == -1)
                                                yyerror("service unknown");
                                          free($1);
                                        }
        | YY_NUMBER                     { $$ = $1; }
--- 1049,1058 ----
        ;

  portnum:
!       servicename                     { $$ = getport(frc, $1);
                                          if ($$ == -1)
                                                yyerror("service unknown");
+                                         $$ = ntohs($$);
                                          free($1);
                                        }
        | YY_NUMBER                     { $$ = $1; }

Reply via email to