On Wed, 2011-12-14 at 04:26 -0800, Zdenek Styblik wrote:
> Hello,
> 
> as you may have noticed, there was thread about ipmitool getting
> stucked. I dug into this issue and found the problem.
> 
> Line to blame is:
> ~~~ 'src/plugins/open/open.c' ~~~
>       if (select(intf->fd+1, &rset, NULL, NULL, NULL) < 0) {
>               lperror(LOG_ERR, "I/O Error");
>               return NULL;
>       }
> ~~~ 'src/plugins/open/open.c' ~~~
> 
> Using select() here is good/wise. However select() is never going to
> time-out, because time-out is set to NULL. I believe I can patch it in
> the very same way, at least for time-out option, as LAN/LAN-PLUS is
> patched by Harshad Prabhu. Yet, I'm wondering whether it is a good
> idea to do so. Whether there is some reason why this, open driver -
> KCS interface, should never ever time-out.

You are correct, it should never time out, but it can for a variety of
reasons.  For example, the BMC is broken or the BMC is too busy
processing other things.

In FreeIPMI, we implemented a timeout b/c we felt it was better to
return an error than let a tool hang.  In the later case, system
administrators that would run a tool in the "background" (e.g. for
monitoring, configing, cronjob, etc.) would have processes in the system
never dieing.

Al

> Thank you for your comments.
> 
> Regards,
> Z.
> 
> ------------------------------------------------------------------------------
> Cloud Computing - Latest Buzzword or a Glimpse of the Future?
> This paper surveys cloud computing today: What are the benefits? 
> Why are businesses embracing it? What are its payoffs and pitfalls?
> http://www.accelacomm.com/jaw/sdnl/114/51425149/
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
-- 
Albert Chu
ch...@llnl.gov
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory



------------------------------------------------------------------------------
Cloud Computing - Latest Buzzword or a Glimpse of the Future?
This paper surveys cloud computing today: What are the benefits? 
Why are businesses embracing it? What are its payoffs and pitfalls?
http://www.accelacomm.com/jaw/sdnl/114/51425149/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to