You are right. I looked at the one at the bug link, not your attachment. Nevermind.
Andy -----Original Message----- From: Duncan Idaho [mailto:dune.id...@gmail.com] Sent: Friday, May 04, 2012 11:55 AM To: Andy Cress Cc: ipmitool-devel@lists.sourceforge.net Subject: Re: [Ipmitool-devel] PATCH - # ipmitool sunoem sshkey; buffer overflow/input validation - ID: 3411421 On Fri, May 4, 2012 at 3:30 PM, Andy Cress <andy.cr...@us.kontron.com> wrote: > Duncan, > > RE: (uid_long < 0) > Unsigned long will never be less than zero. > > RE: (errno != 0) > Technically errno is not set unless the return value indicates an error, > so errno could be non-zero from the last time any error occurred. > > Just delete both of these conditions, and use ULONG_MAX as indicated by > the strtoul man page. > > Andy > Andy, do we really look at the same patch? Because I see none of you're referring to. Thanks, --Duncan ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
