On Fri, May 11, 2012 at 10:16 AM, Jon Bamber <jon_bam...@xyratex.com> wrote:
> Hi
>
> There is code in ipmi_sel.c line 1070 introduce 7 years ago in 1.39 which
> excludes writing the sensor number out in the sel list output when the
> sensor number is zero.
>
> i.e
> if (evt->sel_type.standard_type.sensor_num != 0)
> printf(" #0x%02x",
> evt->sel_type.standard_type.sensor_num);
>
> I cannot see the purpose of this check as it modifies my output from
>
> 23 | Pre-Init |0000000055| Drive Slot #0x00 | Drive Present | Asserted
>
> 24 | Pre-Init |0000000055| Drive Slot #0x01 | Drive Present | Asserted
>
> to
>
> 23 | Pre-Init |0000000055| Drive Slot | Drive Present | Asserted
>
> 24 | Pre-Init |0000000055| Drive Slot #0x01 | Drive Present | Asserted
>
> Does anyone have an explanation for this or could this condition be
> removed?
>
> Thanks
>
> Jon
>
Hello Jon,
I don't have an explanation, but I agree it is pretty weird. And I
agree this could/should be removed, if that's all in that condition.
It looks to me as a bit of inconsistent output.
My $0.02.
--Duncan
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
