All,
I've attached a fix for this based on what was reported in Bug #3568976 and I
verified
this fix resolved the reported problem.
If no one has an problem with this fix, I'll commit the change to TOB at the
end of this
week.
Thanks in Advance,
Jim
-- Jim Mankovich | jm...@hp.com (MST) --
On 9/21/2012 7:51 AM, Jon Bamber wrote:
Dick
I agree with a Zdenek, we use tm.tm_isdst = (-1); in the patch "3497103Settable and shared
sensor sdr" , but you can alos use the option "now" to send the current time which
is useful but undocumented in the help.
Jon
*Jonathan Bamber*
______________________________________________________________________
For additional information including the registered office and the treatment of
Xyratex confidential information please visit www.xyratex.com
______________________________________________________________________
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>From 79e7f26b610ae98968255aec51a36a631be9c43b Mon Sep 17 00:00:00 2001
From: Jim Mankovich <jm...@hp.com>
Date: Mon, 24 Sep 2012 14:04:00 -0600
Subject: [PATCH] Init is daylight savings time to unavailable
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1.7.9.5"
This is a multi-part message in MIME format.
--------------1.7.9.5
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit
"ipmitool sel time set" acts differently when executed explicitly on the command
line vs when executed from a file using "ipmitool exec filename". The
problem is due to lack of initialization of the timeval structure tm_isdst
field. We set the daylight savings time rule to unavailable so mktime will
attempt to determine whether or not DST is in effect. See Bug ID: 3568976
for details.
Signed-off-by: Jim Mankovich <jm...@hp.com>
---
lib/ipmi_sel.c | 1 +
1 file changed, 1 insertion(+)
--------------1.7.9.5
Content-Type: text/x-patch; name="0001-Init-is-daylight-savings-time-to-unavailable.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Init-is-daylight-savings-time-to-unavailable.patch"
diff --git a/lib/ipmi_sel.c b/lib/ipmi_sel.c
index 3c99b66..35bd0b3 100644
--- a/lib/ipmi_sel.c
+++ b/lib/ipmi_sel.c
@@ -2480,6 +2480,7 @@ ipmi_sel_set_time(struct ipmi_intf * intf, const char * time_string)
lprintf(LOG_ERR, "Specified time could not be parsed");
return -1;
}
+ tm.tm_isdst = -1; /* dst information unavailable */
t = mktime(&tm);
if (t < 0) {
lprintf(LOG_ERR, "Specified time could not be parsed");
--------------1.7.9.5--
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
