It is definitely a quick hack around. I am providing our changes as a guide to whoever might address the issue for a future ipmitool release.
Richard Detweiler | T 256-261-6550 -----Original Message----- From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com] Sent: Wednesday, September 26, 2012 5:34 AM To: Detweiler, Dick [NETPWR/AVOCENT/AL] Cc: ipmitool-devel@lists.sourceforge.net Subject: Re: [Ipmitool-devel] New Bug #3571570 - delloem exec file won't handle more than one command On Tue, Sep 25, 2012 at 5:40 PM, <dick.detwei...@emerson.com> wrote: > Hello, > > We found a problem in handling more than one command in the delloem command > block. The bug in sourceforge contains a fix that works for us as an > attachment. > > ipmitool version: 1.8.12 > operating system reproduced on: OpenEmbedded Linux > > How to reproduce: > Create an exec file with the lines: > delloem powermonitor powerconsumption watt delloem powermonitor > powerconsumptionhistory watt > > Execute the same two commands from the ipmitool command line. > Execute the exec file you created. > > Note that the exec file always results in an error for the second command: > "Error getting power headroom status: Command not supported on this system" > > Patches to ipmi_delloem.c and ipmi_shell.c seem to fix the issue and example > patches are included as an attachment. > Hello Dick, I don't have Dell hardware to reproduce reported issue. I've checked patch attached to ticket and I agree calling memset() never hurts. However, have you noticed variable 'current_arg' in 'lib/ipmi_delloem.c' is a global variable? I mean, it feels really odd to modify global variable just like that. Have you debugged it further or is your patch just a quick hack around? Anyway, I have nothing against applying these memset() calls to 'src/ipmishell.c', but I definitely would like to hear from somebody either from Dell or knowledgeable of 'lib/ipmi_delloem.c'. about your patch to 'lib/ipmi_delloem.c'. They definitely will, or should, know better about code in 'lib/ipmi_delloem.c' and what it can or can't do. My $0.02 USD. Take it easy, Z. > Thanks, > Dick > ---------------------------------------------------------------------- > -------- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions will include endpoint security, mobile security and the > latest in malware threats. > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
