On Fri, Dec 28, 2012 at 4:39 PM, <[email protected]> wrote: > Why change the ordering of the arguments in getsysinfo/setsysinfo? > I like it the way it was originally since intf/param/block/set are part of > the input ipmi command and the data/length are the returned data. > > --jordan hargrave > Dell Enterprise Linux Engineering
My reasoning behind the change is: * give these functions same order of common arguments since they're likely to be used together - easier to remember(?) * it seemed like a common way, at least within ipmitool *shrug* Z. > ________________________________________ > From: Zdenek Styblik [[email protected]] > Sent: Thursday, December 27, 2012 2:35 PM > To: Hargrave, Jordan > Cc: Jim Mank; ipmitool-devel > Subject: Code review/changes - 'mc getsysinfo|setsysinfo' - IDs #3598203, > #3597782, #3597781 > > Hello Jordan, > > attached is a diff set I'm going to commit sooner or later. This patch > changes some code around 'mc getsysinfo' and 'mc setsysinfo' you've > committed. > This e-mail is meant as a heads-up and also an opportunity for > questions and comments. > > * > https://sourceforge.net/tracker/?func=detail&aid=3597781&group_id=95200&atid=610550 > * > https://sourceforge.net/tracker/?func=detail&aid=3597782&group_id=95200&atid=610550 > * > https://sourceforge.net/tracker/?func=detail&aid=3598203&group_id=95200&atid=610550 > > Best regards, > Z. > > -- > Zdenek Styblik > email: [email protected] > jabber: [email protected] ------------------------------------------------------------------------------ Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812 _______________________________________________ Ipmitool-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
