----- Original Message ----- > From: "Zdenek Styblik" <zdenek.styb...@gmail.com> > To: "Ales Ledvinka" <aledv...@redhat.com> > Cc: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net> > Sent: Tuesday, January 15, 2013 3:09:25 PM > Subject: Re: Code Review - ID: 3595612 - ask for password once only if used > > On Tue, Jan 15, 2013 at 3:03 PM, Zdenek Styblik > <zdenek.styb...@gmail.com> wrote: > > On Tue, Jan 15, 2013 at 2:54 PM, Ales Ledvinka > > <aledv...@redhat.com> wrote: > > [...] > >> > >> Sure. For the specific corner cases that I overlooked. Unlikely > >> to be used by anyone. Rather then dropping the compatibility > >> for almost anyone by reworking and failing on invalid argument > >> combinations - your proposal. > >> > > > > Automation is not a corner case. But yes. And software develops, > > evolves, things do change.
For documenting the option overrides and groups I already checked the code complexity while parsing options before. The combination of invalid/ignored/overwritten/as is/different default/adaptive at runtime for the multi dimensional issue of options, interfaces, commands, command of commands, subcommand options I consider current approach to be least error prone from the feature accessibility. > > [...] > >> For the -a -f filename example it is: > >> Same variable. > >> Interactive input was dropped. Now not asked for at all. > >> Last occurred option used as before. > >> > > > > Oh, you finally got it? QA perspective? All the time. User perspective? Not yet. > >> Claims to be annoyance removal. Since we do not share the same > >> idea > >> of the bug in the option parsing there is no common resolution of > >> what > >> can be proper fix. > >> > > > > That's right. And I actually gave it an extra thought and I think > > this > > is not something that needs and has to be fixed. Because you're not > > going to police all arguments, which were passed once or N times, > > in > > which order, are you? So what makes '-a' and '-Y' special? Nothing. > > It's just a mere deficiency of getopt() or perhaps it's misuse or > > perhaps just a lack of thought in ipmitool's design. Only shadow > > knows. > > Please, close the ticket as ``Won't fix'' since this is not > > something > > that needs fixing. > > > > Thanks! > > Z. > > I forgot to add; if user puts multiple '-a' or '-Y' on the line and > doesn't mind to be asked N times about password or key, then he sure > knows what he's doing. Let's not think of user as an some kind of ... > errr ... idiot(hopefully not an offensive expression, because none > was > meant). Valid point though comparably weak. Since it has to be the corner case of all corners combined. ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
