On Mon, Apr 1, 2013 at 7:52 PM, Dan Gora <dan.g...@gmail.com> wrote:
[...]
>> I only noticed this because you changed data from unsigned long to unsigned 
>> int.
>
> yes because the structure is only 3 bytes long.  Recall that a long is
> 8 bytes on 64 bit machines.  An unsigned int is always 4 bytes (unless
> we're talking about 16 or 8 bit processors here, which we're not...).
> Longs (unsigned or not) should really be avoided unless you're really
> prepared to deal with them being different sizes or 32 or 64 bit
> machines.
>

Why don't you use int types from "<stdint.h>" that I don't understand.
Is there something wrong about it? Because you'd have equally sized
integers no matter what platform you're currently running at. This
was, actually, one of comments/questions/suggestions I had about
posted patches.

Regards,
Z.

------------------------------------------------------------------------------
Own the Future-Intel&reg; Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game 
on Steam. $5K grand prize plus 10 genre and skill prizes. 
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to