As a fellow IPMI project maintainer, I would side with the opinion the bug is on the BMC. The BMC should not care what the VLAN ID is when it is being disabled, only when it's being enabled.
That said, it would perhaps be nice to get a workaround into ipmitool to deal with this. Perhaps nothing more than a "--vlan-id" or something like that option to allow the user to override the default. Al On Sun, 2016-08-07 at 12:23 +0200, Zdenek Styblik wrote: > On Sun, Aug 7, 2016 at 6:04 AM, <b_b_si...@dell.com> wrote: > > Hi, > > > > Then is it a bug in ipmitool? That it sends 0x000 when VLAN ID is disabled. > > “ipmitool lan set 1 vlan id off” > > > > As per the wiki the ipmitool supposed to send values from 0x001 to 0xFFE > > during VLAN ID disable. > > > > Hello Balaji, > > it's disputable where the bug is. Me, personally, I would say bug is > in your BMC, because there is a little to no reason to send any VLAN > ID when VLAN ID Setting is being disabled. Is there any reason why > client should send any VLAN ID? If my understanding is correct, there > can be only one VLAN ID per channel and it can be either on and then > you need VLAN ID, or off and then VLAN ID doesn't matter. > You're correct, though, that IPMI specification doesn't explicitly say > this. On the other hand, it sort of makes sense. > > Best regards, > Z. > > > > Regards > > > > Balaji Singh > > > > > > > > > > > > From: ^..^ [mailto:zenf...@gmail.com] > > Sent: Saturday, August 6, 2016 11:45 PM > > To: Singh, B B <b_b_si...@dell.com> > > Cc: ipmitool-devel@lists.sourceforge.net > > Subject: Re: [Ipmitool-devel] Can't Disable VLAN ID!!! > > > > > > > > I’d imagine it varies by vender (both BMC & network gear), but wiki has a > > good summation - > > > > VLAN identifier (VID): a 12-bit field specifying the VLAN to which the frame > > belongs. The hexadecimal values of 0x000 and 0xFFF are reserved. All other > > values may be used as VLAN identifiers, allowing up to 4,094 VLANs. The > > reserved value 0x000 indicates that the frame does not carry a VLAN ID; in > > this case, the 802.1Q tag specifies only a priority and is referred to as a > > priority tag. On bridges, VID 0x001 (the default VLAN ID) is often reserved > > for a management VLAN; this is vendor-specific. The VID value 0xFFF is > > reserved for implementation use; it must not be configured or transmitted. > > 0xFFF can be used to indicate a wildcard match in management operations or > > filtering database entries. > > > > Basically you should avoid 0,1, and 4095 unless you know your vendor/hw > > supports it for a specific reason. > > > > > > > > — d > > > > > > > > On Sat, Aug 6, 2016 at 6:07 AM, <b_b_si...@dell.com> wrote: > > > > > > > > Dear IPMI Experts, > > > > > > > > Need your help in understanding what should be value of VLAN ID value during > > VLAN disable. > > > > > > > > The spec doesn’t clearly call out what should be value of VLAN ID when VLAN > > ID enable bit is zero. > > > > > > > > As per spec… > > > > data 1 > > [7:0] - Least significant 8-bits of the VLAN ID. 00h if VLAN ID not used. > > data 2 > > [7] - VLAN ID enable. > > 0b = disabled, 1b = enabled. If enabled, the BMC will only accept packets > > for this > > channel if they have 802.1q fields and their VLAN ID matches the VLAN ID > > value > > given in this parameter. > > [6:4] - reserved > > [3:0] - most significant four bits of the VLAN ID > > > > > > > > > > > > I’m trying to disable the vlan id using the command “ipmitool lan set 1 vlan > > id off” > > > > I get the below error. > > > > LAN Parameter Data does not match! Write may have failed. > > > > > > > > When I checked in code ipmi_lanp.c the ipmitool is sending the vlan id as “0 > > 0” which is NOT accepted by the BMC. > > > > > > > > ipmi_lan_set_vlan_id(struct ipmi_intf *intf, uint8_t chan, char *string) > > { > > uint8_t data[2]; > > int rc; > > > > if (string == NULL) > > > > { data[0] = 0; data[1] = 0; } > > > > > > > > But when I replace the VLAN ID value with 1-4094 along with VLAN ID enable > > bit = 0. I.e, > > > > > > > > Data[0] = xxxx xxxx > > > > Data[1] = 0xxx xxxx > > > > > > > > Then VLAN ID got disable successfully. > > > > > > > > So, my query is what is the expected value of the VLAN ID when VLAN ID > > enable bit is zero as per the spec? should be zero or 1 to 4094 range? > > > > > > > > Regards > > > > Balaji Singh > > > > > > > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > > Ipmitool-devel mailing list > > Ipmitool-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > > > > > > > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > > Ipmitool-devel mailing list > > Ipmitool-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > > > > ------------------------------------------------------------------------------ > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel -- Albert Chu ch...@llnl.gov Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
