Lars Eggert has entered the following ballot position for draft-ietf-ipsecme-ikev1-algo-to-historic-08: No Objection
When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-ipsecme-ikev1-algo-to-historic/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- # GEN AD review of draft-ietf-ipsecme-ikev1-algo-to-historic-08 CC @larseggert Thanks to Roni Even for the General Area Review Team (Gen-ART) review (https://mailarchive.ietf.org/arch/msg/gen-art/rK3E1XT4aINFH14eXi90vEqPa0o). ## Nits All comments below are about very minor potential issues that you may choose to address in some way - or ignore - as you see fit. Some were flagged by automated tools (via https://github.com/larseggert/ietf-reviewtool), so there will likely be some false positives. There is no need to let me know what you did with these suggestions. ### Typos #### Section 4.2, paragraph 1 ``` - method was never standarized in IKEv1. Those IKEv1 systems that + method was never standardized in IKEv1. Those IKEv1 systems that + + ``` ### Outdated references Reference `[RFC4306]` to `RFC4306`, which was obsoleted by `RFC5996` (this may be on purpose). Reference `[RFC2407]` to `RFC2407`, which was obsoleted by `RFC4306` (this may be on purpose). Reference `[RFC2409]` to `RFC2409`, which was obsoleted by `RFC4306` (this may be on purpose). Reference `[RFC2408]` to `RFC2408`, which was obsoleted by `RFC4306` (this may be on purpose). ### URLs These URLs point to tools.ietf.org, which has been taken out of service: * https://tools.ietf.org/id/draft-ietf-ipsecme-labeled-ipsec-06.txt ### Grammar/style #### Section 6, paragraph 1 ``` ocument instructs IANA to add an additional Status column to the IKEv2 Transf ^^^^^^^^^^^^^^^^^^^^^^^^ ``` This phrase might be redundant. Consider either removing or replacing the adjective "additional". #### Section 7, paragraph 5 ``` ment] Figure 3 Transform Type 4 - Diffie Hellman Group Transform IDs Number ^^^^^^^^^^^^^^ ``` This word is normally spelled with a hyphen. ## Notes This review is in the ["IETF Comments" Markdown format][ICMF], You can use the [`ietf-comments` tool][ICT] to automatically convert this review into individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT]. [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md [ICT]: https://github.com/mnot/ietf-comments [IRT]: https://github.com/larseggert/ietf-reviewtool _______________________________________________ IPsec mailing list IPsec@ietf.org https://www.ietf.org/mailman/listinfo/ipsec