On Wed, Feb 06, 2019 at 10:16:44AM -0800, aaron.yo...@oracle.com wrote: > On 02/06/2019 05:42 AM, Geert Stappers wrote: > > On Tue, Feb 05, 2019, Aaron Young wrote: > > > Implement scaffolding for new efimap command. > > > > > ... > > > index 3c14a2c..a902934 100644 > > > --- a/src/config/general.h > > > +++ b/src/config/general.h > > > @@ -154,6 +154,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL ); > > > //#define PROFSTAT_CMD /* Profiling commands */ > > > //#define NTP_CMD /* NTP commands */ > > > //#define CERT_CMD /* Certificate management commands */ > > > +#define EFIMAP_CMD /* EFI Map command */ > > > /* > > > * ROM-specific options > > The new command is default enabled. > > Please advise or clarify your comment.
That I would expect --- a/src/config/general.h +++ b/src/config/general.h @@ -154,6 +154,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL ); //#define PROFSTAT_CMD /* Profiling commands */ //#define NTP_CMD /* NTP commands */ //#define CERT_CMD /* Certificate management commands */ + //#define EFIMAP_CMD /* EFI Map command */ /* * ROM-specific options Or --- a/src/config/general.h +++ b/src/config/general.h @@ -136,6 +136,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL ); #define LOGIN_CMD /* Login command */ #define SYNC_CMD /* Sync command */ #define SHELL_CMD /* Shell command */ +#define EFIMAP_CMD /* EFI Map command */ //#define NSLOOKUP_CMD /* DNS resolving command */ //#define TIME_CMD /* Time commands */ //#define DIGEST_CMD /* Image crypto digest commands */ Yes, I should have raised clearly the question: Should the efimap command be default enabled? > > > > P.S. > > Other ideas how to prevent that patches get lost in email traffic are > > welcome. I'm trying to care about the cool iPXE project. It does happen that submitted patches are unanswered for weeks. Patch submitters will think: "Why should I bother again?" Or "Does really no-one care?" My simple > > The new command is default enabled. was for saying "Some one does care". Cheers Geert Stappers DevOps Engineer at Hendrikx-ITC _______________________________________________ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
