Nice catch! Thanks! Thanks, -John
-----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Wayne Kelly Sent: Wednesday, May 21, 2008 6:08 PM To: [email protected] Subject: Re: [Ironruby-core] Code Review: rails-2 In rbconfig.rb: TOPDIR = File.dirname(__FILE__).chomp!("/lib/ruby/1.8/i386-mswin32") the path "/lib/ruby/1.8/i386-mswin32" needs to be replaced by the tail of the directory path where rbconfig.rb resides. (otherwise chomp! will return nil) Cheers, Wayne. > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > John Lam (IRONRUBY) > Sent: Thursday, 22 May 2008 8:06 AM > To: IronRuby External Code Reviewers > Cc: [email protected] > Subject: [Ironruby-core] Code Review: rails-2 > > tfpt review /shelveset:rails-2;REDMOND\jflam > > This shelveset introduces fixes that are blocking us from > > - Added missing define_method overload for Proc > - Adding missing default constructors to StringIO and StringScanner > - We canonicalize paths returned from a few key File methods (\ -> /) > - Introducing new Ruby\Libs directory to hold our redirect > .rb files and hacks > - Modifying aliases and checking in ir.cmd > - Removing .EXE directory from $: search path > > Thanks, > -John > > _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
