http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#L3L4
* Undo this deletion. That is a valid spec as well. http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#L5R29 * Guards don't go inside of examples. Please split this into two specs: one guarded, the other unguarded. http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#L10L91 * I would keep the :in_block in the spec to be sure that it isn't a no-op Test and .rb changes look good other than that. JD From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Shri Borde Sent: Monday, April 13, 2009 10:14 PM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: [Ironruby-core] Review: Misc fixes http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead GitDiff.bat 5e8c6b232a3c952985adbf1b9cda5c456d503cea 24ce7ba7cdac9a52d3f43dbd77300f5067d31ead * Fixes File.expand_path to workaround a problem "igem i rails" was running into. * Fixes File apis to throw correct exception type * Implements Kernel.abort * Adds Errno::ECONNREFUSED * Exception#message should call Exception#to_s * Fixes paths in rbconfig.rb to work in dev environment Files changed: * .gitignore<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-0> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt<http://github.com/shri/ironruby/tree/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/string/split_tags.txt<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-2> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/message_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-3> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/to_s_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-4> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-5> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/open_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-6> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/rename_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-7> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-8> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/abort_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-9> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/open_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-10> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/string/split_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-11> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-12> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ExceptionOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-13> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-14> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-15> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/MutableStringOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-16> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-17> * Merlin/Main/Languages/Ruby/Libs/rbconfig.rb<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-18> * Merlin/Main/Languages/Ruby/Ruby/Builtins/File.cs<http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-19> Thanks, Shri
_______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
