Looks good. From: Shri Borde Sent: Wednesday, June 03, 2009 11:07 AM To: [email protected] Cc: IronRuby External Code Reviewers Subject: Review: File.expand_path
http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3 Reimplemented File.expand_path such that it does not use System.IO.Path. This allows us to get better compatibility with MRI. The motivating reason was that RSpec does File.expand_path("filename:linenumber"), and the old implementation complained that : is not valid in filenames, whereas MRI allows such input Fixed "[nil].uniq" - Cucumber was running into this. Renamed scripts\ruby19.bat to ruby1.9.bat as "mspec -tr19" seems to have changed. List of files: * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-0> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/array/uniq_spec.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-1> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-2> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Dir.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-3> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-4> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-5> * Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyUtils.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-6> * Merlin/Main/Languages/Ruby/Scripts/RakeTests.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-7> * Merlin/Main/Languages/Ruby/Scripts/ruby1.9.bat<http://github.com/shri/ironruby/tree/ec9eae2e12e97ab53082dbfd35d0d57b337731b3/Merlin/Main/Languages/Ruby/Scripts/ruby1.9.bat> * Merlin/Main/Languages/Ruby/Scripts/ruby19.bat * Merlin/Main/Runtime/Microsoft.Scripting/Utils/ArrayUtils.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3#diff-10> Thanks, Shri
_______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
