Looks good. Tomas
From: Shri Borde Sent: Thursday, July 30, 2009 11:22 AM To: [email protected] Cc: IronRuby External Code Reviewers Subject: Review: break out of Enumerable methods was not working http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2 * break out of Enumerable methods was not working (http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1301) * Added tests for all the methods in uncategorized_spec.rb. * Removed workaround in tutorial that is no longer needed as a result * Relexed an assert in RubyExceptionData.cs that was firing. Files: * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/BuiltinsOps.cs<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-0> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ArrayOps.cs<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-1> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Enumerable.cs<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-2> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/StructOps.cs<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-3> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-4> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-5> * Merlin/Main/Languages/Ruby/Ruby/Hosting/RubyOptionsParser.cs<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-6> * Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyExceptionData.cs<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-7> * Merlin/Main/Languages/Ruby/Samples/Tutorial/README.markdown<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-8> * Merlin/Main/Languages/Ruby/Samples/Tutorial/html_tutorial.rb<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-9> * Merlin/Main/Languages/Ruby/Samples/Tutorial/wpf.rb<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-10> * Merlin/Main/Languages/Ruby/Tests/Interop/net/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/963ab8bb90163fd204978c5726c2104ce70c52c2#diff-11> Thanks, Shri
_______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
