Looks good. Tomas
From: Shri Borde Sent: Wednesday, August 05, 2009 12:30 PM To: [email protected] Cc: IronRuby External Code Reviewers Subject: Review: clean irtests.bat run Thanks to Ray and Kevin for reporting all the issues and investigating them to get to the root of the irtests.bat problems! http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3 * Fixes a bunch of issues preventing irtests.bat from running cleanly on some machines: - Checking in Ruby\Tests\interop\net\A\a.generated.dll etc which fixes 3 test failures in the RubySpec A suite - Changed gemutilities.rb so that the RubyGems tests can work even if TMP is the 8.3 form of a long name (something like c:\DOCUME~1\JANEDO~1\LOCALS~1\Temp). One test still fails, which I disabled in RubyGems.rb - Disables a Time#_load test which only works for PST - Changed RakeTest to avoid printing an all-caps message "SKIPPING FUNCTIONAL TESTS BECAUSE THE SESSION GEM IS NOT IMPLIED" which was implying that you should install the session gem, but this gem does not work on Windows * Fix for regex bug - http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1895 * Added a splash screen to the tutorial Files changed: * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/RubyGems-1_3_1-test/gemutilities.rb<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-0> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/dir/getwd_tags.txt<http://github.com/shri/ironruby/tree/cccdde9db683aeedbb48550bfaf0254ce50b53e3/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/dir/getwd_tags.txt> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/dir/pwd_tags.txt<http://github.com/shri/ironruby/tree/cccdde9db683aeedbb48550bfaf0254ce50b53e3/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/dir/pwd_tags.txt> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/time/_load_tags.txt<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-3> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/dir/getwd_spec.rb<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-4> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/dir/shared/pwd.rb<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-5> * Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyRegex.cs<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-6> * Merlin/Main/Languages/Ruby/Samples/Tutorial/README.markdown<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-7> * Merlin/Main/Languages/Ruby/Samples/Tutorial/wpf/SplashScreen.cs<http://github.com/shri/ironruby/tree/cccdde9db683aeedbb48550bfaf0254ce50b53e3/Merlin/Main/Languages/Ruby/Samples/Tutorial/wpf/SplashScreen.cs> * Merlin/Main/Languages/Ruby/Samples/Tutorial/wpf/SplashScreen.dll<http://github.com/shri/ironruby/tree/cccdde9db683aeedbb48550bfaf0254ce50b53e3/Merlin/Main/Languages/Ruby/Samples/Tutorial/wpf/SplashScreen.dll> * Merlin/Main/Languages/Ruby/Samples/Tutorial/wpf/SplashScreen.png<http://github.com/shri/ironruby/tree/cccdde9db683aeedbb48550bfaf0254ce50b53e3/Merlin/Main/Languages/Ruby/Samples/Tutorial/wpf/SplashScreen.png> * Merlin/Main/Languages/Ruby/Samples/Tutorial/wpf_tutorial.rb<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-11> * Merlin/Main/Languages/Ruby/Scripts/bin/tutorial.bat<http://github.com/shri/ironruby/tree/cccdde9db683aeedbb48550bfaf0254ce50b53e3/Merlin/Main/Languages/Ruby/Scripts/bin/tutorial.bat> * Merlin/Main/Languages/Ruby/Tests/Interop/net/A/a.generated.dll<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-13> * Merlin/Main/Languages/Ruby/Tests/Interop/net/B/b.generated.dll<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-14> * Merlin/Main/Languages/Ruby/Tests/Interop/net/fixtures.generated.cs<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-15> * Merlin/Main/Languages/Ruby/Tests/Interop/net/fixtures.generated.dll<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-16> * Merlin/Main/Languages/Ruby/Tests/Scripts/RakeTests.rb<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-17> * Merlin/Main/Languages/Ruby/Tests/Scripts/RubyGemsTests.rb<http://github.com/shri/ironruby/commit/cccdde9db683aeedbb48550bfaf0254ce50b53e3#diff-18> Thanks, Shri
_______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
