> Could you factor the file search out into a private method? Done ...
> I noticed that -S should use the first file it finds on the path, can > you do a spec for that? ... and done (though, isn't that the definition of the path? =P) Attached diff, or tfpt review "/shelveset:dash_upper_s;REDMOND\jimmysch" ~Jimmy > -----Original Message----- > From: Jimmy Schementi > Sent: Sunday, January 17, 2010 2:52 AM > To: ironruby-core@rubyforge.org > Cc: IronRuby External Code Reviewers > Subject: Code Review: dash_s > > -S finds the file being run on the environment's PATH, rather than requiring > the full path to be provided. > > Adds the -S command-line option (for example: ir -S irb) > http://github.com/jschementi/ironruby/commit/135d5e5715409a194191c51c05668636 > 03f49e16 > > Add spec for -S > http://github.com/jschementi/ironruby/commit/62f211de25d1e7c7793b4f9af36cfde3 > 670247f8
dash_upper_s.diff
Description: dash_upper_s.diff
_______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
