[ https://issues.apache.org/jira/browse/IMPALA-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476761#comment-16476761 ]
ASF subversion and git services commented on IMPALA-5384: --------------------------------------------------------- Commit 670cd55b3910f9e4a488254eaee14321935b108e in impala's branch refs/heads/2.x from [~dhecht] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=670cd55 ] IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock For consistency with the other locks in this class, use SpinLock rather than boost::mutex. We expect SpinLock to work okay for locks that block since it is adaptive. This came up in the code review for IMPALA-5384, but I wanted to make this change separately, just in case of unforseen side-effects. Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3 Reviewed-on: http://gerrit.cloudera.org:8080/10392 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > Simplify coordinator locking protocol > ------------------------------------- > > Key: IMPALA-5384 > URL: https://issues.apache.org/jira/browse/IMPALA-5384 > Project: IMPALA > Issue Type: Improvement > Affects Versions: Impala 2.9.0 > Reporter: Marcel Kornacker > Assignee: Dan Hecht > Priority: Major > Fix For: Impala 2.13.0, Impala 3.1.0 > > > The coordinator has a central lock (lock_) which is used very liberally to > synchronize state changes that don't need to be synchronized, creating a > concurrency bottleneck. > Also, the coordinator contains a number of data structures related to INSERT > finalization that don't need to be part of and synchronized with the rest of > the coordinator state. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org