[ 
https://issues.apache.org/jira/browse/IMPALA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480153#comment-16480153
 ] 

ASF subversion and git services commented on IMPALA-7025:
---------------------------------------------------------

Commit 14c715c02bdb2285f14e3defc55dae6cdc9acd6b in impala's branch 
refs/heads/2.x from [~tarmstr...@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=14c715c ]

IMPALA-7025: ignore resources in some planner test

The issue was that the tablesample test verified the mem-estimate
number, which depends on file sizes, which can vary slightly between
data loads.

Instead of trying to tweak the test to avoid the issue, instead provide
a mechanism to ignore the exact values of resources in planner tests
where they are not significant.

Testing:
Manually modified some values in tablesample.test, made sure that the
test still passed. Manually modified the partition count in the
expected output, made sure that the test failed.

Change-Id: I91e3e416ec6242fbf22d9f566fdd1ce225cb16ac
Reviewed-on: http://gerrit.cloudera.org:8080/10410
Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> PlannerTest.testTableSample has wrong mem-reservation
> -----------------------------------------------------
>
>                 Key: IMPALA-7025
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7025
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>    Affects Versions: Impala 3.1.0
>            Reporter: Joe McDonnell
>            Assignee: Tim Armstrong
>            Priority: Critical
>              Labels: broken-build, flaky
>             Fix For: Impala 2.13.0, Impala 3.1.0
>
>
> Seen once on master exhaustive:
> {noformat}
> Error Message
> Section PLAN of query:
> select id from functional_parquet.alltypes tablesample system(10) 
> repeatable(1234)
> Actual does not match expected result:
> F00:PLAN FRAGMENT [UNPARTITIONED] hosts=1 instances=1
> |  Per-Host Resources: mem-estimate=16.00MB mem-reservation=8.00KB 
> thread-reservation=2
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> PLAN-ROOT SINK
> |  mem-estimate=0B mem-reservation=0B thread-reservation=0
> |
> 00:SCAN HDFS [functional_parquet.alltypes]
>    partitions=3/24 files=3 size=23.70KB
>    stored statistics:
>      table: rows=unavailable size=unavailable
>      partitions: 0/24 rows=unavailable
>      columns: unavailable
>    extrapolated-rows=disabled max-scan-range-rows=unavailable
>    mem-estimate=16.00MB mem-reservation=8.00KB thread-reservation=1
>    tuple-ids=0 row-size=4B cardinality=unavailable
> Expected:
> F00:PLAN FRAGMENT [UNPARTITIONED] hosts=1 instances=1
> |  Per-Host Resources: mem-estimate=16.00MB mem-reservation=16.00KB 
> thread-reservation=2
> PLAN-ROOT SINK
> |  mem-estimate=0B mem-reservation=0B thread-reservation=0
> |
> 00:SCAN HDFS [functional_parquet.alltypes]
>    partitions=3/24 files=3 size=24.23KB
>    stored statistics:
>      table: rows=unavailable size=unavailable
>      partitions: 0/24 rows=unavailable
>      columns: unavailable
>    extrapolated-rows=disabled max-scan-range-rows=unavailable
>    mem-estimate=16.00MB mem-reservation=16.00KB thread-reservation=1
>    tuple-ids=0 row-size=4B cardinality=unavailable{noformat}
> This succeeded on the next build, so it is flaky and might not recur.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to