[ https://issues.apache.org/jira/browse/IMPALA-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong resolved IMPALA-3873. ----------------------------------- Resolution: Later Assignee: (was: Henry Robinson) No sense in keeping a code cleanup JIRA open and untouched for years > Proxy class for QueryExecState and QueryStateRecord > --------------------------------------------------- > > Key: IMPALA-3873 > URL: https://issues.apache.org/jira/browse/IMPALA-3873 > Project: IMPALA > Issue Type: Improvement > Components: Backend > Affects Versions: Impala 2.6.0 > Reporter: Henry Robinson > Priority: Minor > Labels: observability > > {{ImpalaServer}} keeps historical query information in two forms: > # {{QueryExecState}} is for actively executing queries > # {{QueryStateRecord}} is an archive of the final state of a query. > In several places, most often in the debug page generators, we want to treat > these as the same object because we're pulling the same data out from each of > them. This leads to repeated code like: > {code} > if (query_id in active list) { > // Pull out relevant data from QueryExecState > } else if (query_id in archive log) { > // Pull out relevant data from QueryStateRecord > } else { > // Handle not found case > } > {code} > and it would obviously be better to write: > {code} > if (query_id in either active list or archive log) { > // Pull out relevant data from common data structure > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org