[ 
https://issues.apache.org/jira/browse/IMPALA-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776604#comment-16776604
 ] 

ASF subversion and git services commented on IMPALA-6305:
---------------------------------------------------------

Commit 1219d8fb11358c36284e459e0b9fd37d26f44df9 in impala's branch 
refs/heads/2.x from poojanilangekar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1219d8f ]

IMPALA-6305: Allow column definitions in ALTER VIEW

This change adds support to change column definitions in ALTER VIEW
statements. This support only required minor changes in the parser
and the AlterViewStmt constructor.

Here's an example syntax:
    alter view foo (a, b comment 'helloworld') as
    select * from bar;

    describe foo;
    +------+--------+------------+
    | name | type   | comment    |
    +------+--------+------------+
    | a    | string |            |
    | b    | string | helloworld |
    +------+--------+------------+

The following tests were modified:
1. ParserTest - To check that the parser handles column definitions
   for alter view statements.
2. AnalyzerDDLTest - To ensure that the analyzer supports the
   change column definitions parsed.
3. TestDdlStatements - To verify the end-to-end functioning of
   ALTER VIEW statements with change column definitions.
4. AuthorizationTest - To ensure that alter table commands with
   column definitions check permissions as expected.

Change-Id: I6073444a814a24d97e80df15fcd39be2812f63fc
Reviewed-on: http://gerrit.cloudera.org:8080/10720
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> Allow column definitions in ALTER VIEW
> --------------------------------------
>
>                 Key: IMPALA-6305
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6305
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Frontend
>            Reporter: Alexander Behm
>            Assignee: Pooja Nilangekar
>            Priority: Major
>              Labels: sql-language
>             Fix For: Impala 2.13.0, Impala 3.1.0
>
>
> When working with views we currently only allow separate column definitions 
> in CREATE VIEW but not in ALTER VIEW.
> Example:
> {code}
> create table t1 (c1 int, c2 int);
> create view v (x comment 'hello world', y) as select * from t1;
> describe v;
> +------+------+-------------+
> | name | type | comment     |
> +------+------+-------------+
> | x    | int  | hello world |
> | y    | int  |             |
> +------+------+-------------+
> {code}
> Currently we cannot use ALTER VIEW to change the column definitions after the 
> fact, i.e. the following should be supported:
> {code}
> alter view v (z1, z2 comment 'foo bar') as select * from t1;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to