[ https://issues.apache.org/jira/browse/IMPALA-5397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780988#comment-16780988 ]
ASF subversion and git services commented on IMPALA-5397: --------------------------------------------------------- Commit 793e8192efae3b777717408b41b3787e681968c6 in impala's branch refs/heads/master from poojanilangekar [ https://gitbox.apache.org/repos/asf?p=impala.git;h=793e819 ] IMPALA-5397: Set query's end_time_us_ when the operation completes Previously, a query's end time was set only when UnregisterQuery() was called. This was misleading because the query could have completed earlier. After this change, if the query has a coordinator, the end time is set when the query releases its admission control resources. For queries without coordinators, (e.g. DDL queries), the end time would still be set when UnregisterQuery() is called. Testing: Added a test to ensure that the end time is set before the query is closed for a query with a coordinator. It also ensures that for a query without a coordinator, the end time is set only when the query is closed. Tested queries with various settings of --idle-query-timeout. Ran exhaustive end-to-end tests and the stress test without any failures. Change-Id: Iaa9a1b443df3dbd95f9f297c2f923ad795b14745 Reviewed-on: http://gerrit.cloudera.org:8080/12583 Reviewed-by: Bikramjeet Vig <bikramjeet....@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > Set "End Time" earlier rather than on unregistration. > ----------------------------------------------------- > > Key: IMPALA-5397 > URL: https://issues.apache.org/jira/browse/IMPALA-5397 > Project: IMPALA > Issue Type: Bug > Components: Backend > Affects Versions: Impala 2.9.0 > Reporter: Mostafa Mokhtar > Assignee: Pooja Nilangekar > Priority: Major > Labels: admission-control, query-lifecycle > > When queries are executed from Hue and hit the idle query timeout then the > query duration keeps going up even though the query was cancelled and it is > not actually doing any more work. The end time is only set when the query is > actually unregistered. > Queries below finished in 1s640ms while the reported time is much longer. > |User||Default Db||Statement||Query Type||Start Time||Waiting > Time||Duration||Scan Progress||State||Last Event||# rows fetched||Resource > Pool||Details||Action| > |hue/va1026.halxg.cloudera....@halxg.cloudera.com|tpcds_1000_parquet|select > count(*) from tpcds_1000_parquet.inventory|QUERY|2017-05-31 > 09:38:20.472804000|4m27s|4m32s|261 / 261 ( 100%)|FINISHED|First row > fetched|1|root.default|Details|Close| > |hue/va1026.halxg.cloudera....@halxg.cloudera.com|tpcds_1000_parquet|select > count(*) from tpcds_1000_parquet.inventory|QUERY|2017-05-31 > 08:38:52.780237000|2017-05-31 09:38:20.289582000|59m27s|261 / 261 ( > 100%)|FINISHED|1|root.default|Details| -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org