[ https://issues.apache.org/jira/browse/IMPALA-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783927#comment-16783927 ]
ASF subversion and git services commented on IMPALA-8249: --------------------------------------------------------- Commit dc1bc3ca03337d6d63d88261226047bb7a55493b in impala's branch refs/heads/master from Zoltan Borok-Nagy [ https://gitbox.apache.org/repos/asf?p=impala.git;h=dc1bc3c ] IMPALA-8249: End-to-end test framework doesn't read aggregated counters properly Updated compute_aggregation() function to not read the pretty-printed value from the runtime profile, but the accurate value which is at the end of the line in parenthesis, e.g.: RowsReturned: 2.14M (2142543) The old regex tried to parse '2.14M' with 'd+', which resulted in '2' instead of 2142543. I tested the change manually and added a test case to 'tests/unittests/test_result_verifier.py'. Change-Id: I2a6fc0d3f7cbaa87aa848cdafffad21fb1514930 Reviewed-on: http://gerrit.cloudera.org:8080/12589 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > End-to-end test framework doesn't read aggregated counters properly > ------------------------------------------------------------------- > > Key: IMPALA-8249 > URL: https://issues.apache.org/jira/browse/IMPALA-8249 > Project: IMPALA > Issue Type: Bug > Reporter: Zoltán Borók-Nagy > Assignee: Zoltán Borók-Nagy > Priority: Major > > The test framework doesn't always read the correct value of counters from the > runtime profile. In the .test files we can have a RUNTIME_PROFILE section > where we can test our expectations against runtime profile data. We can even > calculate aggregates of runtime data, currently only SUM is supported over > integer data, e.g.: > {code:java} > ---- RUNTIME_PROFILE > aggregation(SUM, RowsReturned): 2142543 > {code} > However, the counters are pretty-printed in the runtime profile, which means > that if they are greater than 1000, a shortened version is printed first, > then the accurate number comes in parenthesis , e.g.: > {code:java} > RowsReturned: 2.14M (2142543){code} > When the test framework parses the value of an aggregated counter, it > wrongly tries to parse the short version as a number, which returns a wrong > value (2 instead of 2142543 in the example). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org