[ 
https://issues.apache.org/jira/browse/IMPALA-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801998#comment-16801998
 ] 

ASF subversion and git services commented on IMPALA-8340:
---------------------------------------------------------

Commit ed9e1d499b3a3e6e30386dc11e55b6907eaaf409 in impala's branch 
refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ed9e1d4 ]

IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Fixes in IMPALA-8317 and IMPALA-8337 introduced third-party dependencies
in Impala shell which is problematic in multi-Python environment. This
patch rewrites the fixes using an alternative solution when dealing with
duplicate options without any third-party dependencies. For example:

[impala]
keyval=msg1=hello,keyval=msg2=world

Testing:
- Ran all shell tests on Python 2.6 and 2.7.
- Ran make_shell_tarball.sh and ran Impala shell from the tarball
  without any issue.

Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Reviewed-on: http://gerrit.cloudera.org:8080/12844
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> IMPALA-8337 adds configparser dependency which isn't always available where 
> impala-shell is installed
> -----------------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-8340
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8340
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>            Reporter: Tim Armstrong
>            Assignee: Fredy Wijaya
>            Priority: Blocker
>              Labels: broken-build
>
> This may break other things. I've seen some failures on systems like this:
> {noformat}
> Command exited with code: 1
> Command output: Traceback (most recent call last):
>   File "/usr/lib/impala-shell/impala_shell.py", line 42, in <module>
>     from option_parser import get_option_parser, get_config_from_file
>   File "/usr/lib/impala-shell/lib/option_parser.py", line 30, in <module>
>     import configparser
> ImportError: No module named configparser
> {noformat}
> I think we would need to add configparser to shell/ext-py so that it's 
> packaged with the rest of the shell stuff. I'm not sure if there are other 
> steps too



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to