[
https://issues.apache.org/jira/browse/IMPALA-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816407#comment-16816407
]
radford nguyen commented on IMPALA-8389:
----------------------------------------
This issue was fixed in the following commit, but the commit message
erroneously referenced IMPALA-8363.
Commit f998d64767c074216e75a552b36ecf44ff295d07 in impala's branch
refs/heads/master from Radford Nguyen
[ [https://gitbox.apache.org/repos/asf?p=impala.git;h=f998d64] ]
IMPALA-8363: Fix E2E start with impala_log_dir
This commit fixes the `CustomClusterTestSuite` to wait for the
correct number of executors when `impala_log_dir` is specified
in the test decorator. Previously, the default value of 3
was always used, regardless of `cluster_size`.
Testing:
- Manual verification using tests/authorization/test_ranger.py
with custom `impala_log_dir` and `cluster_size` arguments.
Failed before changes, passed after changes
- Ran all original E2E tests
Change-Id: I4f46f40474b4b380abe88647a37e8e4d2231d745
Reviewed-on: [http://gerrit.cloudera.org:8080/12935]
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> e2e custom cluster testsuite does not respect cluster_size when
> impala_log_dir present
> --------------------------------------------------------------------------------------
>
> Key: IMPALA-8389
> URL: https://issues.apache.org/jira/browse/IMPALA-8389
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 3.2.0
> Reporter: radford nguyen
> Assignee: radford nguyen
> Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> h3. Brief
> CustomClusterTestSuite always waits for 3 daemons on startup instead of
> {{cluster_size}} daemons when {{impala_log_dir}} is specified.
> h3. Description
> The {{@CustomClusterTestSuite.withArgs}} decorator allows a user to specify a
> custom cluster size for the test case being decorated. However, when this
> option is specified in conjunction with {{impala_log_dir}}, it will fail to
> wait for the correct number of daemons if any value other than
> {{DEFAULT_CLUSTER_SIZE}} is used.
> The root cause is the difference in how the cluster is started with and
> without {{impala_log_dir}}:
> [https://github.com/apache/impala/blob/3.2.0/tests/common/custom_cluster_test_suite.py#L147]
> h3. To Reproduce:
> * add {{cluster_size=5}} to decorator of test_grant_revoke in
> tests/authorization/test_ranger.py
> * $ impala-py.test tests/authorization/test_ranger.py
> * observe pass
> * add {{impala_log_dir=whatev}} to decorator of test_grant_revoke
> * $ impala-py.test tests/authorization/test_ranger.py
> * observe fail during cluster startup:
> ** 2019-04-04 14:25:54,140 INFO MainThread: Waiting for
> num_known_live_backends=3. Current value: 5
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
