[ https://issues.apache.org/jira/browse/IMPALA-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827103#comment-16827103 ]
Greg Rahn commented on IMPALA-4018: ----------------------------------- [~gaborkaszab], [~maze] - I'm strongly against introducing any behavior that makes the new CAST(...FORMAT...) syntax not follow the SQL:2016 contract, even via a feature flag. I am, however, ok with introducing a flag to bring the legacy date masks and functions into ISO SQL compliance (and provide a UX that matches the expectations of DBMS users). Here is the main reason why: SQL tools need to be "taught" how to convert to and from these types and formats and there has to be only correct way to do so. There is no way to teach a tool conditional logic based on feature flags. We're working with vendors to add the new SQL:2016 syntax into their tools so there can be only one correct way and that way has to adhere to the contract that other SQL systems will adopt and use as well. I hope this makes it clear on why we need to follow and converge on ISO/ANSI SQL behaviors. > Add support for SQL:2016 datetime templates/patterns/masks to CAST(... AS ... > FORMAT <template>) > ------------------------------------------------------------------------------------------------ > > Key: IMPALA-4018 > URL: https://issues.apache.org/jira/browse/IMPALA-4018 > Project: IMPALA > Issue Type: New Feature > Components: Frontend > Affects Versions: Impala 2.2.4 > Reporter: Greg Rahn > Assignee: Gabor Kaszab > Priority: Critical > Labels: ansi-sql, compatibility, sql-language > > *Summary* > The format masks/templates for currently are implemented using the [Java > SimpleDateFormat > patterns|http://docs.oracle.com/javase/8/docs/api/java/text/SimpleDateFormat.html], > and although this is what Hive has implemented, it is not what most standard > SQL systems implement. For example see > [Vertica|https://my.vertica.com/docs/7.2.x/HTML/Content/Authoring/SQLReferenceManual/Functions/Formatting/TemplatePatternsForDateTimeFormatting.htm], > > [Netezza|http://www.ibm.com/support/knowledgecenter/SSULQD_7.2.1/com.ibm.nz.dbu.doc/r_dbuser_ntz_sql_extns_templ_patterns_date_time_conv.html], > > [Oracle|https://docs.oracle.com/database/121/SQLRF/sql_elements004.htm#SQLRF00212], > and > [PostgreSQL|https://www.postgresql.org/docs/9.5/static/functions-formatting.html#FUNCTIONS-FORMATTING-DATETIME-TABLE]. > > *Examples of incompatibilities* > {noformat} > -- PostgreSQL/Netezza/Vertica/Oracle > select to_timestamp('May 15, 2015 12:00:00', 'mon dd, yyyy hh:mi:ss'); > -- Impala > select to_timestamp('May 15, 2015 12:00:00', 'MMM dd, yyyy HH:mm:ss'); > -- PostgreSQL/Netezza/Vertica/Oracle > select to_timestamp('2015-02-14 20:19:07','yyyy-mm-dd hh24:mi:ss'); > -- Impala > select to_timestamp('2015-02-14 20:19:07','yyyy-MM-dd HH:mm:ss'); > -- Vertica/Oracle > select to_timestamp('2015-02-14 20:19:07.123456','yyyy-mm-dd hh24:mi:ss.ff'); > -- Impala > select to_timestamp('2015-02-14 20:19:07.123456','yyyy-MM-dd > HH:mm:ss.SSSSSS'); > {noformat} > *Considerations* > Because this is a change in default behavior for to_timestamp(), if possible, > having a feature flag to revert to the legacy Java SimpleDateFormat patterns > should be strongly considered. This would allow users to chose the behavior > they desire and scope it to a session if need be. > SQL:2016 defines the following datetime templates > {noformat} > <datetime template> ::= > { <datetime template part> }... > <datetime template part> ::= > <datetime template field> > | <datetime template delimiter> > <datetime template field> ::= > <datetime template year> > | <datetime template rounded year> > | <datetime template month> > | <datetime template day of month> > | <datetime template day of year> > | <datetime template 12-hour> > | <datetime template 24-hour> > | <datetime template minute> > | <datetime template second of minute> > | <datetime template second of day> > | <datetime template fraction> > | <datetime template am/pm> > | <datetime template time zone hour> > | <datetime template time zone minute> > <datetime template delimiter> ::= > <minus sign> > | <period> > | <solidus> > | <comma> > | <apostrophe> > | <semicolon> > | <colon> > | <space> > <datetime template year> ::= > YYYY | YYY | YY | Y > <datetime template rounded year> ::= > RRRR | RR > <datetime template month> ::= > MM > <datetime template day of month> ::= > DD > <datetime template day of year> ::= > DDD > <datetime template 12-hour> ::= > HH | HH12 > <datetime template 24-hour> ::= > HH24 > <datetime template minute> ::= > MI > <datetime template second of minute> ::= > SS > <datetime template second of day> ::= > SSSSS > <datetime template fraction> ::= > FF1 | FF2 | FF3 | FF4 | FF5 | FF6 | FF7 | FF8 | FF9 > <datetime template am/pm> ::= > A.M. | P.M. > <datetime template time zone hour> ::= > TZH > <datetime template time zone minute> ::= > TZM > {noformat} > SQL:2016 also introduced the FORMAT clause for CAST which is the standard way > to do string <> datetime conversions > {noformat} > <cast specification> ::= > CAST <left paren> > <cast operand> AS <cast target> > [ FORMAT <cast template> ] > <right paren> > <cast operand> ::= > <value expression> > | <implicitly typed value specification> > <cast target> ::= > <domain name> > | <data type> > <cast template> ::= > <character string literal> > {noformat} > For example: > {noformat} > CAST(<datetime> AS <char string type> [FORMAT <template>]) > CAST(<char string> AS <datetime type> [FORMAT <template>]) > cast(dt as string format 'DD-MM-YYYY') > cast('01-05-2017' as date format 'DD-MM-YYYY') > {noformat} > *Update* > Here is the proposal for the new datetime patterns and their semantics: > https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/ -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org