[ 
https://issues.apache.org/jira/browse/IMPALA-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839685#comment-16839685
 ] 

ASF subversion and git services commented on IMPALA-8528:
---------------------------------------------------------

Commit 5a23bacdba9f199948b6a971aebca30586c360a5 in impala's branch 
refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5a23bac ]

IMPALA-8528: Refactor authorization check in AnalysisContext

This patch moves the authorization check logic from AnalysisContext
into BaseAuthorizationChecker to consolidate the logic into a single
place. This patch also converts AuthorizationChecker into an interface
The existing implementation code of AuthorizationChecker is now moved to
BaseAuthorizationChecker.

This patch has no functionality change.

Testing:
- Ran FE tests
- Ran E2E authorization tests

Change-Id: I3bc3a11220dae0f49ef3e73d9ff27a90e9d4a71c
Reviewed-on: http://gerrit.cloudera.org:8080/13285
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> Refactor authorization code from AnalysisContext to AuthorizationChecker
> ------------------------------------------------------------------------
>
>                 Key: IMPALA-8528
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8528
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Frontend
>            Reporter: Fredy Wijaya
>            Assignee: Fredy Wijaya
>            Priority: Critical
>             Fix For: Impala 3.3.0
>
>
> Currently the authorization code is scattered in few places, such as 
> AnalysisContext and AuthorizationChecker. This makes it difficult to add 
> things such as doing pre and post authorization check for audit logging, etc. 
> We need to consolidate the authorization code into a single place and perhaps 
> make AuthorizationChecker as an interface and create a 
> BaseAuthorizationChecker that contains many useful authorization methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to