[ 
https://issues.apache.org/jira/browse/IMPALA-8589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880706#comment-16880706
 ] 

radford nguyen commented on IMPALA-8589:
----------------------------------------

While this ticket did improve the wait time on expected-failing tests, I don't 
think it actually fixed the "flakiness" of the passing case.  The 
{{test_query_event_hooks_execute}} test case originally checked for execution 
of {{QueryEventHook.onQueryComplete}}, but now only checks for 
{{QueryEventHook.onImpalaStartup}}.

Since {{onQueryComplete}} executes asynchronously and {{onImpalaStartup}} does 
not, I think this is the reason that the flakiness of the tests has gone away.  
We probably need to restore coverage for {{onQueryComplete}} execution at some 
point. 

> Fix flaky query event hook tests
> --------------------------------
>
>                 Key: IMPALA-8589
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8589
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Infrastructure
>            Reporter: Fredy Wijaya
>            Assignee: Fredy Wijaya
>            Priority: Major
>             Fix For: Impala 3.3.0
>
>
> The test_query_event_hooks.py tests is flaky. We need to figure out a way to 
> deflake it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to