[
https://issues.apache.org/jira/browse/IMPALA-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894964#comment-16894964
]
ASF subversion and git services commented on IMPALA-8799:
---------------------------------------------------------
Commit d412c4b69d2ec7fc01d4e21d4316fb367b488f4d in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d412c4b ]
IMPALA-8799: prefix Prometheus metrics with "impala_"
If the converted metric name does not already start with
"impala_", we add the prefix. This makes it easier to
separate Impala metrics from metrics from other systems
that may also be present in prometheus. It is documented
as a good practice, see:
https://prometheus.io/docs/practices/naming/
Testing:
* Added a targeted unit test for the name transformation.
* Updated unit tests to reflect the new names.
* Manually inspected /metrics_prometheus output.
Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f
Reviewed-on: http://gerrit.cloudera.org:8080/13941
Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Prometheus metrics should be prefixed with "impala_"
> ----------------------------------------------------
>
> Key: IMPALA-8799
> URL: https://issues.apache.org/jira/browse/IMPALA-8799
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Labels: observability
>
> This is recommended by the Prometheus docs -
> https://prometheus.io/docs/practices/naming/
> {quote}
> A metric name...
> ...must comply with the data model for valid characters.
> ...should have a (single-word) application prefix relevant to the domain
> the metric belongs to. The prefix is sometimes referred to as namespace by
> client libraries. For metrics specific to an application, the prefix is
> usually the application name itself. Sometimes, however, metrics are more
> generic, like standardized metrics exported by client libraries. Examples:
> prometheus_notifications_total (specific to the Prometheus server)
> process_cpu_seconds_total (exported by many client libraries)
> http_request_duration_seconds (for all HTTP requests)
> {quote}
> It is also awkward in tools like grafana to find impala metrics with the
> current naming scheme.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
