[ 
https://issues.apache.org/jira/browse/IMPALA-7726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968501#comment-16968501
 ] 

ASF subversion and git services commented on IMPALA-7726:
---------------------------------------------------------

Commit e8fda1f224d3ad237183a53e238eee90188d82e2 in impala's branch 
refs/heads/master from Sahil Takiar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e8fda1f ]

IMPALA-9117, IMPALA-7726: Fixed a few unit tests for ABFS

This test makes the following changes / fixes when running Impala tests
on ABFS:
* Skips some tests in test_lineage.py that don't work on ABFS / ADLS
(they were already skipped for S3)
* Skips some tests in test_mt_dop.py; the test creates a directory that
ends with a period (and ABFS does not support writing files or
directories that end with a period)
* Removes the ABFS skip flag SkipIfABFS.trash (IMPALA-7726: Drop with
purge tests fail against ABFS due to trash misbehavior"); I removed
these flags and looped the tests overnight with no failures, so it is
likely whatever bug was causing this has now been fixed
* Now that HADOOP-15860 has been resolved, and the agreed upon behavior
for ABFS is that it will fail if a client tries to write a file /
directory that ends with a period, I added a new entry to the SkipIfABFS
class called file_or_folder_name_ends_with_period and applied it where
necessary

Testing:
* Ran core tests on ABFS

Change-Id: I18ae5b0f7de6aa7628a1efd780ff30a0cc3c5285
Reviewed-on: http://gerrit.cloudera.org:8080/14636
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> Drop with purge tests fail against ABFS due to trash misbehavior
> ----------------------------------------------------------------
>
>                 Key: IMPALA-7726
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7726
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Major
>              Labels: flaky
>
> In testing IMPALA-7681, I've seen test_drop_partition_with_purge and 
> test_drop_table_with_purge fail because of files not found in the trash are a 
> drop without purge. I've traced that functionality through Hive, which uses 
> Hadoop's Trash API, and traced through a bunch of scenarios in that API with 
> ABFS and I can't see it misbehaving in any way. It also should be pretty 
> FS-agnostic. I also suspected a bug in abfs_utils.py's exists() function, but 
> have not been able to find one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to