[ https://issues.apache.org/jira/browse/IMPALA-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024691#comment-17024691 ]
ASF subversion and git services commented on IMPALA-9311: --------------------------------------------------------- Commit 567b3cd04c7ecd43282127c47b21f177ecb9a2b5 in impala's branch refs/heads/master from Anurag Mantripragada [ https://gitbox.apache.org/repos/asf?p=impala.git;h=567b3cd ] IMPALA-9311: Store SQLPrimaryKeys in canonical order. HMS seems to be returning SQLPrimaryKeys in inconsistent orders. This makes some of the primary keys tests flaky. This change sorts the list of primary keys and stores them in canonical order within Impala. Testing: - Modified the tests that were relying on HMS to return same order every time. - Ran parametrized job. Change-Id: I0f798d7a2659c6cd061002db151f3fa787eb6370 Reviewed-on: http://gerrit.cloudera.org:8080/15106 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> > test_show_create_table failed with primary key mismatch > ------------------------------------------------------- > > Key: IMPALA-9311 > URL: https://issues.apache.org/jira/browse/IMPALA-9311 > Project: IMPALA > Issue Type: Test > Affects Versions: Impala 3.4.0 > Reporter: Xiaomeng Zhang > Assignee: Anurag Mantripragada > Priority: Major > Labels: broken-build > > {code:java} > Error Messagemetadata/test_show_create_table.py:62: in test_show_create_table > unique_database) metadata/test_show_create_table.py:110: in > __run_show_create_table_test_case self.__compare_result(expected_result, > create_table_result) metadata/test_show_create_table.py:146: in > __compare_result assert expected_sql_filtered == actual_sql_filtered E > assert "CREATE EXTER...parent_table'" == "CREATE EXTERN...parent_table'" E > Skipping 71 identical leading characters in diff, use -v to show E > Skipping 126 identical trailing characters in diff, use -v to show E - > MARY KEY (year, id)) ROW FO E ? ---- E + MARY KEY (id, > year)) ROW FO E ? > ++++Stacktracemetadata/test_show_create_table.py:62: in test_show_create_table > unique_database) > metadata/test_show_create_table.py:110: in __run_show_create_table_test_case > self.__compare_result(expected_result, create_table_result) > metadata/test_show_create_table.py:146: in __compare_result > assert expected_sql_filtered == actual_sql_filtered > E assert "CREATE EXTER...parent_table'" == "CREATE EXTERN...parent_table'" > E Skipping 71 identical leading characters in diff, use -v to show > E Skipping 126 identical trailing characters in diff, use -v to show > E - MARY KEY (year, id)) ROW FO > E ? ---- > E + MARY KEY (id, year)) ROW FO > E ? ++++{code} > I think this is due to commit > [https://github.com/apache/impala/commit/cfe60858da110cf1256bd3aa5d4f8d374578a33d] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org