[ https://issues.apache.org/jira/browse/IMPALA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041373#comment-17041373 ]
ASF subversion and git services commented on IMPALA-9366: --------------------------------------------------------- Commit e04a839d9c000c9652519d5e76bbe280ceb1114d in impala's branch refs/heads/master from Bikramjeet Vig [ https://gitbox.apache.org/repos/asf?p=impala.git;h=e04a839 ] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters The handcrafted codegen method in PhjBuilder::CodegenInsertRuntimeFilters embeds direct pointer references to filter contexts. This patch replaces those with references to the input parameters instead. Testing: Successfully ran core tests for joins and runtime filters. Change-Id: I09037b5832b037536bde9324f7a2a10778511114 Reviewed-on: http://gerrit.cloudera.org:8080/15186 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > Remove embedded pointer references in handcrafted codegen code > -------------------------------------------------------------- > > Key: IMPALA-9366 > URL: https://issues.apache.org/jira/browse/IMPALA-9366 > Project: IMPALA > Issue Type: Sub-task > Reporter: Bikramjeet Vig > Assignee: Bikramjeet Vig > Priority: Major > > Currently I was only able to find one such instance here > (PhjBuilder::CodegenInsertRuntimeFilters) where pointers to filter contexts > were embedded in the codegened code. > there might be more so creating this Jira for handling all those instances -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org