[
https://issues.apache.org/jira/browse/IMPALA-9534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068120#comment-17068120
]
Sahil Takiar commented on IMPALA-9534:
--------------------------------------
I've discussed this with the Hive folks, and looks like this was a mistake. The
intention is to use 'TRUE'. apache master Hive actually uses 'TRUE'. The Hive
team is making a fix for this.
> Kudu show create table tests fail due to case difference for
> external.table.purge
> ---------------------------------------------------------------------------------
>
> Key: IMPALA-9534
> URL: https://issues.apache.org/jira/browse/IMPALA-9534
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Affects Versions: Impala 4.0
> Reporter: Joe McDonnell
> Assignee: Sahil Takiar
> Priority: Blocker
> Labels: broken-build
>
> When updating to the latest CDP GBN, there are test failures due to our tests
> expecting external.table.purge=TRUE (upper case) whereas it is actually
> external.table.purge=true (lower case):
>
> {noformat}
> query_test/test_kudu.py:862: in test_primary_key_and_distribution
> db=cursor.conn.db_name, kudu_addr=KUDU_MASTER_HOSTS))
> query_test/test_kudu.py:836: in assert_show_create_equals
> assert "TBLPROPERTIES ('external.table.purge'='TRUE', " in output
> E assert "TBLPROPERTIES ('external.table.purge'='TRUE', " in "CREATE
> EXTERNAL TABLE testshowcreatetable_6928_i0obd1.jlxsrpzmcu (\n c INT NOT NULL
> ENCODING AUTO_ENCODING COMPRESSI...H (c) PARTITIONS 3\nSTORED AS
> KUDU\nTBLPROPERTIES ('external.table.purge'='true',
> 'kudu.master_addresses'='localhost')"{noformat}
> This impacts the following tests:
>
>
> {noformat}
> metadata.test_ddl.TestDdlStatements.test_create_alter_tbl_properties
> metadata.test_show_create_table.TestShowCreateTable.test_show_create_table
> query_test.test_kudu.TestShowCreateTable.test_primary_key_and_distribution
> query_test.test_kudu.TestShowCreateTable.test_timestamp_default_value
> query_test.test_kudu.TestShowCreateTable.test_managed_kudu_table_name_with_show_create
> org.apache.impala.catalog.local.LocalCatalogTest.testKuduTable{noformat}
> I think we can just make these case insensitive.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
