[ 
https://issues.apache.org/jira/browse/IMPALA-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153871#comment-17153871
 ] 

Sean Yeh edited comment on IMPALA-5078 at 7/8/20, 7:31 PM:
-----------------------------------------------------------

I have split expr-test.cc by moving Dates/Times/Strings into a new file. 
However, I have a couple of issues I need help with. 
 # I cannot bootstrap a developer's environment. Whenever I run the script, I 
am given the error "fatal error: kudu/util/hash.pb.h: No such file or 
directory". I didn't see the file in the Apache Impala Github Repo and couldn't 
find any similar issues online. I use virtual box to host a Ubuntu 16.04 vm. 
I've included a screenshot in a separate comment for more information.
 # I'm trying to compile the files to make sure they still run fine. The 
command "g++ filename" or "gcc filename" does not work. What's the best way to 
compile the two new files I have split? Alternatively when my developer's 
environment issue is resolved, could I just grep where expr-test.cc is and 
replace expr-test.cc with the two files I split it into?


was (Author: sy117):
I have split expr-test.cc by moving Dates/Times/Strings into a new file. 
However, I have a couple of issues I need help with. 
 # I cannot bootstrap a developer's environment. Whenever I run the script, I 
am given the error "fatal error: kudu/util/hash.pb.h: No such file or 
directory". I didn't see the file in the Apache Impala Github Repo and couldn't 
find any similar issues online. I use virtual box to host a Ubuntu 16.04 vm. 
 # I'm trying to compile the files to make sure they still run fine. The 
command "g++ filename" or "gcc filename" does not work. What's the best way to 
compile the two new files I have split? Alternatively when my developer's 
environment issue is resolved, could I just grep where expr-test.cc is and 
replace expr-test.cc with the two files I split it into?

> Break up expr-test.cc
> ---------------------
>
>                 Key: IMPALA-5078
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5078
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Henry Robinson
>            Assignee: Sean Yeh
>            Priority: Minor
>              Labels: newbie, ramp-up
>         Attachments: Screen Shot 2020-06-30 at 12.19.16 PM.png
>
>
> {{expr-test.cc}} clocks in at 7129 lines, which is about enough for my emacs 
> to start slowing down a bit. Let's see if we can refactor it enough to have a 
> couple of test files. Maybe moving all the string instructions into a 
> separate {{expr-string-test.cc}}, and having a common header will be enough 
> to make it a bit more manageable. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to