[ 
https://issues.apache.org/jira/browse/IMPALA-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235164#comment-17235164
 ] 

ASF subversion and git services commented on IMPALA-897:
--------------------------------------------------------

Commit 47dbfde0b2cabd14452f18527e954aec5891224c in impala's branch 
refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=47dbfde ]

IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test.

This test for IMPALA-897 is testing that queries run by Impala Shell
from a script file are closed correctly.  This is tested by an assertion
that there is one in-flight query during execution of a script
containing several queries. The test then closes the shell and checks
that there are no in-flight queries. This is the assertion which failed.
Change this assertion to instead wait for the number of in-flight
queries to be zero. This avoids whatever race was causing the flakiness.

Change-Id: Ib0485097c34282523ed0df6faa143fee6f74676d
Reviewed-on: http://gerrit.cloudera.org:8080/16743
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> impala-shell does not close queries after completion when running them from a 
> script file
> -----------------------------------------------------------------------------------------
>
>                 Key: IMPALA-897
>                 URL: https://issues.apache.org/jira/browse/IMPALA-897
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>    Affects Versions: Impala 1.3
>            Reporter: Lenni Kuff
>            Assignee: Lenni Kuff
>            Priority: Blocker
>              Labels: shell
>             Fix For: Impala 1.3
>
>
> For example, if a script like this is run:
> {code}
> select 1;
> select 1;
> select 1;
> select 1;
> select 1;
> select sleep(30000);
> {code}
> The queries are not actually closed until the session disconnects. This 
> causes major problems with admission control because queries start to get 
> rejected because they are still in-flight.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to