[ https://issues.apache.org/jira/browse/IMPALA-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong resolved IMPALA-1193. ----------------------------------- Resolution: Won't Fix > Restructure error handling within the impala-shell > -------------------------------------------------- > > Key: IMPALA-1193 > URL: https://issues.apache.org/jira/browse/IMPALA-1193 > Project: IMPALA > Issue Type: Improvement > Components: Clients > Affects Versions: Impala 1.4 > Reporter: Abdullah Yousufi > Priority: Minor > Labels: shell > > Take a look at comments (in patch set 1 and 6) > http://gerrit.sjc.cloudera.com:8080/#/c/4100/. > Essentially, the main points are to move the main control loop of the shell > (while shell_is_alive loop) into the shell class. Second, the exception > handling that occurs in the _execute_stmt() method should be moved to the top > level so errors are caught by the main control loop for interactive mode and > at the loop within execute_queries_non_interactive_mode() for non-interactive > mode. > To prevent redundant error handling, the two respective loops should be > wrapped/decorated or call the same method that then handles all the errors. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org