[
https://issues.apache.org/jira/browse/IMPALA-10744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369012#comment-17369012
]
ASF subversion and git services commented on IMPALA-10744:
----------------------------------------------------------
Commit 6cc357a54c2dd3f98f88c7517e821c037da9f292 in impala's branch
refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6cc357a ]
IMPALA-10765: Allow firing INSERT events with empty results
When INSERT or the INSERT part of a CTAS statement produces empty
results, catalogd will hit a Precondition check in createInsertEvents()
if the statement is not specified with OVERWRITE. This patch removes the
checks to relax the restriction. This is consistent with Hive since Hive
also fires insert events on empty insert results.
Previously when event processor is disabled, we won't generate INSERT
events. This is inconsistent with other DDL events which will always be
generated by Hive. This patch removes the check on event processor's
status. So firing INSERT events is independent to the event processor.
This fixes IMPALA-10744.
Tests
- Add e2e test
Change-Id: Id708f38302b37d7e09435e7b8b0c9fc071659606
Reviewed-on: http://gerrit.cloudera.org:8080/17629
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Send INSERT events even when Impala's even processing is not enabled
> --------------------------------------------------------------------
>
> Key: IMPALA-10744
> URL: https://issues.apache.org/jira/browse/IMPALA-10744
> Project: IMPALA
> Issue Type: Bug
> Components: Catalog
> Reporter: Zoltán Borók-Nagy
> Priority: Major
>
> Generating insert events should not be conditional to events processor being
> active or not.
> Related code:
> https://github.com/apache/impala/blob/d99caa1f3a049fc5e20855f8e8bf846fd81f65c5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L5124
> Please note that this will also need to fix a bug in the createInsertEvents()
> code as an INSERT with an empty result set raises an IllegalStateException:
> create table ctas_empty as select * from functional.alltypes limit 0;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
