[ 
https://issues.apache.org/jira/browse/IMPALA-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486722#comment-17486722
 ] 

ASF subversion and git services commented on IMPALA-9057:
---------------------------------------------------------

Commit d59ec73990d89bfa4d4fa3d8fe598d53eb2918b7 in impala's branch 
refs/heads/master from Yu-Wen Lai
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d59ec73 ]

IMPALA-11093: Fine grained table refreshing doesn't refresh table file
metadata

If we insert data into an acid partitioned table from Hive, the
generated events will be like open_txn -> alter_partition
-> commit_txn.

Previously we assumed the partition object with the alter_partition
event has write id < current write id. However, that is not a valid
assumption, the partition object is actually the write id allocated
in this transaction. That means in commit_txn event, we will have
a partition with write id equals to the write id of cached partition.
So we need to modify the '<' condition to '<='.

Tests:
After IMPALA-10923, we now refresh file metadata while processing
commit events. Therefore, we can add back the test disabled in
IMPALA-9057.

Change-Id: Idabeb522525c45f000ca0992348660fa5a5d4d2d
Reviewed-on: http://gerrit.cloudera.org:8080/18175
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-by: Sourabh Goyal <soura...@cloudera.com>
Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com>


> TestEventProcessing.test_insert_events_transactional is flaky
> -------------------------------------------------------------
>
>                 Key: IMPALA-9057
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9057
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>    Affects Versions: Impala 3.4.0
>            Reporter: Alice Fan
>            Assignee: Vihang Karajgaonkar
>            Priority: Blocker
>              Labels: build-failure, flaky
>
> Assertion failure for 
> custom_cluster.test_event_processing.TestEventProcessing.test_insert_events_transactional
>  
> {code:java}
> Error Message
> assert ['101', 'x', ..., '3', '2019'] == ['101', 'z', '28', '3', '2019']   At 
> index 1 diff: 'x' != 'z'   Full diff:   - ['101', 'x', '28', '3', '2019']   ? 
>          ^   + ['101', 'z', '28', '3', '2019']   ?          ^
> Stacktrace
> custom_cluster/test_event_processing.py:49: in 
> test_insert_events_transactional
>     self.run_test_insert_events(is_transactional=True)
> custom_cluster/test_event_processing.py:131: in run_test_insert_events
>     assert data.split('\t') == ['101', 'z', '28', '3', '2019']
> E   assert ['101', 'x', ..., '3', '2019'] == ['101', 'z', '28', '3', '2019']
> E     At index 1 diff: 'x' != 'z'
> E     Full diff:
> E     - ['101', 'x', '28', '3', '2019']
> E     ?          ^
> E     + ['101', 'z', '28', '3', '2019']
> E     ?          ^
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to