[ 
https://issues.apache.org/jira/browse/IMPALA-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Mate updated IMPALA-9147:
-------------------------------
    Target Version: Impala 4.2.0  (was: Impala 4.1.0)

> The E2E tests in min_max_filters.test do not exercise the code paths in 
> min-max-filter.cc 
> ------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-9147
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9147
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Fang-Yu Rao
>            Assignee: Fang-Yu Rao
>            Priority: Major
>
> The E2E tests in min_max_filters.test do not exercise the code paths in 
> {{min-max-filter.cc}}. This could be verified by commenting out the return 
> statement at 
> [https://github.com/apache/impala/blob/master/be/src/util/min-max-filter.cc#L684],
>  and then run the corresponding E2E tests defined in {{min_max_filters.test}}.
> {code:java}
> $IMPALA_HOME/bin/impala-py.test 
> tests/query_test/test_runtime_filters.py::TestMinMaxFilters::test_min_max_filters
> {code}
> After commenting out that return statement in {{min-max-filter.cc}}, we 
> expect to hit a DCHECK at 
> https://github.com/apache/impala/blob/master/be/src/util/min-max-filter.cc#L698.
>  But according to my observation we are not able to hit that DCHECK, implying 
> that the test query at 
> https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test#L48-L50
>  does not trigger the code paths within 
> https://github.com/apache/impala/blob/master/be/src/util/min-max-filter.cc#L655-L699.
> We hence need to improve these E2E tests so that the respective code paths 
> are exercised.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to